Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renames Atomics.wake => Atomics.notify #1220

Merged
merged 1 commit into from
Aug 1, 2018
Merged

Renames Atomics.wake => Atomics.notify #1220

merged 1 commit into from
Aug 1, 2018

Conversation

rwaldron
Copy link
Contributor

@rwaldron rwaldron commented Jun 8, 2018 •
edited by leobalter
Loading

@ljharb ljharb added normative change Affects behavior required to correctly evaluate some ECMAScript source text needs consensus This needs committee consensus before it can be eligible to be merged. labels Jun 8, 2018
@ljharb ljharb requested a review from syg June 8, 2018 17:51
@jridgewell
Copy link
Member

@ljharb: Didn't we achieve consensus in May?

I can't check, the docs are now restricted access and the notes haven't been published...

@ljharb
Copy link
Member

ljharb commented Jun 8, 2018

I thought we did, but i wasn't sure, due to the wording in the OP. Let's get those notes out ASAP so we can confirm.

@rwaldron
Copy link
Contributor Author

rwaldron commented Jun 8, 2018

I'm still waiting on a summary, but the notes are published now: https://tc39.github.io/tc39-notes/2018-05_toc.html. The checkbox items above are copied verbatim from the notes: https://tc39.github.io/tc39-notes/2018-05_may-22.html#conclusionresolution-rename-atomicswake

Also relevant: nodejs/node#21219

@rwaldron
Copy link
Contributor Author

Turns out those occurrences of https://github.com/EpicGames/UnrealEngine that I found are public copies of a private repo. In order to get access, I will need to:

  • be an Unreal Engine subscriber.
  • have a GitHub account.
  • have associated your GitHub account with your Unreal Engine account as described on the UE4 on GitHub page.

(According to https://docs.unrealengine.com/en-us/GettingStarted/DownloadingUnrealEngine)

This was referenced Jun 22, 2018
Closed
Closed
Closed
@littledan
Copy link
Member

littledan commented Jun 24, 2018 •
edited
Loading

The outreach effort seems really good, and I'm glad you're doing it, but I don't think we need to wait on landing this change until the outreach effort is complete. I bet unshipping and hopefully soon re-shipping SharedArrayBuffer provides enough chaos that this will not be the same kind of "break the web" event as we've seen with other TC39 changes. At the same time, it's important that this patch does land soon, if we want to do it, so as to avoid potential future web compat issues.

cc @binji

@targos targos mentioned this pull request Jul 3, 2018
Merged
targos added a commit to nodejs/node that referenced this pull request Jul 3, 2018
@targos
2018-07-04, Version 10.6.0 (Current)
1f713d6 
Notable changes:

* build:
  * Node.js should now be about 60% faster to startup than the previous version,
    thanks to the use V8's code cache feature for core modules. [#21405](#21405)
* dns:
  * An experimental promisified version of the dns module is now available. Give
    it a try with `require('dns').promises`. [#21264](#21264)
* fs:
  * `fs.lchown` has been undeprecated now that libuv supports it. [#21498](#21498)
* lib:
  * `Atomics.wake` is being renamed to `Atomics.notify` in the ECMAScript
    specification ([reference](tc39/ecma262#1220)).
    Since Node.js now has experimental support for worker threads, we are being
    proactive and added a `notify` alias, while emitting a warning if
    `wake` is used. [#21413](#21413) [#21518](#21518)
* n-api:
  * Add API for asynchronous functions. [#17887](#17887)
* util:
  * `util.inspect` is now able to return a result instead of throwing when the
    maximum call stack size is exceeded during inspection. [#20725](#20725)
* vm:
  * Add `script.createCachedData()`. This API replaces the `produceCachedData`
    option of the `Script` constructor that is now deprecated. [#20300](#20300)
* worker:
  * Support for relative paths has been added to the `Worker` constructor. Paths
    are interpreted relative to the current working directory. [#21407](#21407)

PR-URL: #21629
targos added a commit to nodejs/node that referenced this pull request Jul 4, 2018
@targos
2018-07-04, Version 10.6.0 (Current)
4716fd1 
Notable changes:

* dns:
  * An experimental promisified version of the dns module is now available. Give
    it a try with `require('dns').promises`. [#21264](#21264)
* fs:
  * `fs.lchown` has been undeprecated now that libuv supports it. [#21498](#21498)
* lib:
  * `Atomics.wake` is being renamed to `Atomics.notify` in the ECMAScript
    specification ([reference](tc39/ecma262#1220)).
    Since Node.js now has experimental support for worker threads, we are being
    proactive and added a `notify` alias, while emitting a warning if
    `wake` is used. [#21413](#21413) [#21518](#21518)
* n-api:
  * Add API for asynchronous functions. [#17887](#17887)
* util:
  * `util.inspect` is now able to return a result instead of throwing when the
    maximum call stack size is exceeded during inspection. [#20725](#20725)
* vm:
  * Add `script.createCachedData()`. This API replaces the `produceCachedData`
    option of the `Script` constructor that is now deprecated. [#20300](#20300)
* worker:
  * Support for relative paths has been added to the `Worker` constructor. Paths
    are interpreted relative to the current working directory. [#21407](#21407)

PR-URL: #21629
targos added a commit to nodejs/node that referenced this pull request Jul 4, 2018
@targos
2018-07-04, Version 10.6.0 (Current)
7951e6d 
Notable changes:

* dns:
  * An experimental promisified version of the dns module is now available. Give
    it a try with `require('dns').promises`. [#21264](#21264)
* fs:
  * `fs.lchown` has been undeprecated now that libuv supports it. [#21498](#21498)
* lib:
  * `Atomics.wake` is being renamed to `Atomics.notify` in the ECMAScript
    specification ([reference](tc39/ecma262#1220)).
    Since Node.js now has experimental support for worker threads, we are being
    proactive and added a `notify` alias, while emitting a warning if
    `wake` is used. [#21413](#21413) [#21518](#21518)
* n-api:
  * Add API for asynchronous functions. [#17887](#17887)
* util:
  * `util.inspect` is now able to return a result instead of throwing when the
    maximum call stack size is exceeded during inspection. [#20725](#20725)
* vm:
  * Add `script.createCachedData()`. This API replaces the `produceCachedData`
    option of the `Script` constructor that is now deprecated. [#20300](#20300)
* worker:
  * Support for relative paths has been added to the `Worker` constructor. Paths
    are interpreted relative to the current working directory. [#21407](#21407)

PR-URL: #21629
@ljharb ljharb added has consensus This has committee consensus. and removed needs consensus This needs committee consensus before it can be eligible to be merged. labels Jul 24, 2018
@ljharb ljharb mentioned this pull request Jul 24, 2018
Open
@ljharb ljharb added the needs test262 tests The proposal should specify how to test an implementation. Ideally via github.com/tc39/test262 label Jul 24, 2018
@ljharb
Copy link
Member

ljharb commented Jul 24, 2018

Tests are here: tc39/test262#1614 will update the label once merged.

@leobalter leobalter mentioned this pull request Jul 24, 2018
Merged
@ljharb ljharb added has test262 tests and removed needs test262 tests The proposal should specify how to test an implementation. Ideally via github.com/tc39/test262 labels Jul 24, 2018
@rwaldron
Copy link
Contributor Author

@ljharb merged!

@ljharb ljharb requested review from bterlson and bmeck July 24, 2018 19:04
@littledan
Copy link
Member

We reaffirmed consensus on this change in the July 2018 TC39 meeting. Is this patch ready to merge, then?

@ljharb
Copy link
Member

ljharb commented Jul 27, 2018

Yes - see
#1220 (comment) - and we'll review it in our next editors' call.

@ljharb ljharb assigned ljharb and unassigned bterlson Aug 1, 2018
@ljharb ljharb merged commit fb23016 into master Aug 1, 2018
@ljharb ljharb deleted the atomics-notify branch August 1, 2018 19:50
@ljharb ljharb mentioned this pull request Aug 22, 2018
Merged
@binji binji mentioned this pull request Sep 13, 2018
Closed
@mathiasbynens mathiasbynens mentioned this pull request Apr 23, 2019
Open
ljharb added a commit to ljharb/ecma262 that referenced this pull request Sep 16, 2019
@ljharb
Editorial: update Annex E with incompatibilities from previous editions
c1aa31a 
 - 2016: the Unicode change affected what was considered whitespace (tc39#300 / 24dad16)
 - 2018: changed tagged template literal objects to be cached per source location rather than per realm (tc39#890)
 - 2019: Atomics.wake was renamed to Atomics.notify (tc39#1220)
 - 2019: `await` was changed to require fewer ticks (tc39#1250)
@ljharb ljharb mentioned this pull request Sep 16, 2019
Merged
ljharb added a commit to ljharb/ecma262 that referenced this pull request Sep 16, 2019
@ljharb
Editorial: update Annex E with incompatibilities from previous editions
15a837d 
 - 2016: the Unicode change affected what was considered whitespace (tc39#300 / 24dad16)
 - 2018: changed tagged template literal objects to be cached per source location rather than per realm (tc39#890)
 - 2019: Atomics.wake was renamed to Atomics.notify (tc39#1220)
 - 2019: `await` was changed to require fewer ticks (tc39#1250)
ljharb added a commit to ljharb/ecma262 that referenced this pull request Sep 17, 2019
@ljharb
Editorial: update Annex E with incompatibilities from previous editions
fc17894 
 - 2016: the Unicode change affected what was considered whitespace (tc39#300 / 24dad16)
 - 2017: the latest version of Unicode is mandated (tc39#620)
 - 2018: changed tagged template literal objects to be cached per source location rather than per realm (tc39#890)
 - 2019: Atomics.wake was renamed to Atomics.notify (tc39#1220)
 - 2019: `await` was changed to require fewer ticks (tc39#1250)
ljharb added a commit to ljharb/ecma262 that referenced this pull request Oct 1, 2019
@ljharb
Editorial: update Annex E with incompatibilities from previous editions
e847e97 
 - 2016: the Unicode change affected what was considered whitespace (tc39#300 / 24dad16)
 - 2017: the latest version of Unicode is mandated (tc39#620)
 - 2018: changed tagged template literal objects to be cached per source location rather than per realm (tc39#890)
 - 2019: Atomics.wake was renamed to Atomics.notify (tc39#1220)
 - 2019: `await` was changed to require fewer ticks (tc39#1250)
ljharb added a commit to ljharb/ecma262 that referenced this pull request Oct 17, 2019
@ljharb
Editorial: update Annex E with incompatibilities from previous editio…
16f66d9 
…ns (tc39#1698)

 - 2016: the Unicode change affected what was considered whitespace (tc39#300 / 24dad16)
 - 2017: the latest version of Unicode is mandated (tc39#620)
 - 2018: changed tagged template literal objects to be cached per source location rather than per realm (tc39#890)
 - 2019: Atomics.wake was renamed to Atomics.notify (tc39#1220)
 - 2019: `await` was changed to require fewer ticks (tc39#1250)
ljharb added a commit to ljharb/ecma262 that referenced this pull request Oct 17, 2019
@ljharb
Editorial: update Annex E with incompatibilities from previous editio…
64e53a3 
…ns (tc39#1698)

 - 2016: the Unicode change affected what was considered whitespace (tc39#300 / 24dad16)
 - 2017: the latest version of Unicode is mandated (tc39#620)
 - 2018: changed tagged template literal objects to be cached per source location rather than per realm (tc39#890)
 - 2019: Atomics.wake was renamed to Atomics.notify (tc39#1220)
 - 2019: `await` was changed to require fewer ticks (tc39#1250)
ljharb added a commit to ljharb/ecma262 that referenced this pull request Oct 18, 2019
@ljharb
Editorial: update Annex E with incompatibilities from previous editio…
b1593ec 
…ns (tc39#1698)

 - 2016: the Unicode change affected what was considered whitespace (tc39#300 / 24dad16)
 - 2017: the latest version of Unicode is mandated (tc39#620)
 - 2018: changed tagged template literal objects to be cached per source location rather than per realm (tc39#890)
 - 2019: Atomics.wake was renamed to Atomics.notify (tc39#1220)
 - 2019: `await` was changed to require fewer ticks (tc39#1250)
@katharosada katharosada mentioned this pull request Jan 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmeck bmeck bmeck approved these changes

@ljharb ljharb ljharb approved these changes

@bterlson bterlson bterlson approved these changes

@syg syg Awaiting requested review from syg

Assignees

@ljharb ljharb

Labels
has consensus This has committee consensus. has test262 tests normative change Affects behavior required to correctly evaluate some ECMAScript source text
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rwaldron @jridgewell @ljharb @littledan @bterlson @bmeck