Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fwatcher: fix recursion detect issue for linux platform #266

Merged
merged 2 commits into from
Sep 22, 2024

Conversation

Sunrisepeak
Copy link
Contributor

use -1 to set recursion limit(align to bsd-impl)

use -1 to set recursion limit(align to bsd-impl)

Signed-off-by: SPeak <[email protected]>
@Sunrisepeak
Copy link
Contributor Author

同时也修了一下 bsd, 应为当 recursion = false, walk 0 的时候 对应的就是未修改的linux下recursion 为true的实现 实际会监听两层

watching watch_test/** ..
watch_test/test.txt modified
watch_test/test.txt modified
watch_test/test.txt modified
watch_test/test.txt modified
watch_test/dir1/t.text modified
watch_test/dir1/t.text modified
watch_test/dir1/t.text modified
watch_test/dir1/t.text modified
watch_test/dir1/t.text modified
watch_test/dir1/t.text modified

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


At the same time, I also revised the bsd. It should be that when recursion = false, walk 0, it corresponds to the unmodified implementation of recursion as true under Linux. It will actually monitor two layers.

watching watch_test/** ..
watch_test/test.txt modified
watch_test/test.txt modified
watch_test/test.txt modified
watch_test/test.txt modified
watch_test/dir1/t.text modified
watch_test/dir1/t.text modified
watch_test/dir1/t.text modified
watch_test/dir1/t.text modified
watch_test/dir1/t.text modified
watch_test/dir1/t.text modified

@waruqi waruqi changed the base branch from master to dev September 22, 2024 13:26
@waruqi waruqi merged commit f815e56 into tboox:dev Sep 22, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants