obfuscate should be a regular function

[timoxley]

The way obfuscate is used with setters/getters is rather unusual. It should probably just be a obfuscate static+instance method and a deobfuscate static method.

i.e. instead of:

// obfuscate
var foo = new FooModel(data)
var obfuscated = foo.obfuscate

// deobfuscate
var emptyFoo = new FooModel()
emptyFoo.deobfuscate = obfuscated

More like:

// obfuscate
var foo = new FooModel(data)
var obfuscated = foo.obfuscate() // OR
obfuscated = FooModel.obfuscate(foo.obfuscate) 

// deobfuscate
FooModel.deobfuscate(obfuscated)

IMO, using getters/setters like this doesn't adequately communicate the intent of the code, the telltale sign being that obfuscate and deobfuscate are verbs, thus should probably be functions, rather than properties.

Also, this gets rid of the need for a dummy object during deobfuscation i.e. emptyFoo.