Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[building] - turn off panics #50

Open
nothingismagick opened this issue May 26, 2020 · 4 comments
Open

[building] - turn off panics #50

nothingismagick opened this issue May 26, 2020 · 4 comments
Labels
enhancement Does it add or improve content?
Milestone

Comments

@nothingismagick
Copy link
Member

While discussing errors, @wusyong recommended this approach:

tauri-apps/tauri#613 (comment)

Basically on release stop errors from propegating (because during reversing this information can be very useful to the attacker).

[profile.release]
panic = "abort"
@Laegel
Copy link
Member

Laegel commented May 26, 2020

Should it be done manually or automatically on build?
Maybe automatically and optionally defined by users?

@nothingismagick
Copy link
Member Author

default: off, opt-in?

@Laegel
Copy link
Member

Laegel commented May 26, 2020

Maybe "on" for tauri dev and "off" for tauri build and let users force it globally.
That looks like something that should remain at dev level, right?
Anyway, this issue is not about specifications for this demand, I digress, haha.

Alright, I suggest to put that part in the current "App Publishing" part.

@wusyong
Copy link
Member

wusyong commented May 27, 2020

I found a tweet thread might be interesting to you. And this article on "Operational errors vs. programmer errors".

So I pretty much agree to abort on panic in release build. Not sure what will tauri dev does internally. But if it's somehow equivalent to debug build in cargo, I think that's reasonable to still do stack unwind then.

@github-project-automation github-project-automation bot moved this to 📬Proposal in Roadmap Sep 26, 2023
@github-project-automation github-project-automation bot moved this to 🪵 Backlog in Documentation Feb 26, 2024
@simonhyll simonhyll added this to the Version 1.x milestone Feb 26, 2024
@simonhyll simonhyll added the enhancement Does it add or improve content? label May 23, 2024
@simonhyll simonhyll moved this from 🪵 Backlog to 💪 Ready in Documentation May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Does it add or improve content?
Projects
Status: 💪 Ready
Development

No branches or pull requests

4 participants