Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatting issues #2355

Closed
simonhyll opened this issue Jul 2, 2024 · 2 comments
Closed

Fix formatting issues #2355

simonhyll opened this issue Jul 2, 2024 · 2 comments
Assignees
Labels
bug Does it fix inaccurate content or fix a bug? good first issue Is it good for beginners to take up?
Milestone

Comments

@simonhyll
Copy link
Contributor

One or two issues have snuck into the codebase, someone should fix them.

@simonhyll simonhyll added good first issue Is it good for beginners to take up? bug Does it fix inaccurate content or fix a bug? labels Jul 2, 2024
@simonhyll simonhyll added this to the Version 2.x milestone Jul 2, 2024
@github-project-automation github-project-automation bot moved this to 🪵 Backlog in Documentation Jul 2, 2024
@simonhyll simonhyll moved this from 🪵 Backlog to 💪 Ready in Documentation Jul 2, 2024
@FabianLars
Copy link
Member

I have a local branch locally where i'm working on this but i wanna finish #2313 beforehand

@simonhyll simonhyll moved this from 💪 Ready to 🏗️ In progress in Documentation Jul 4, 2024
@FabianLars
Copy link
Member

Okay so that escalated quite a bit, the mentioned branch simply removed broken mdx files from .prettierignore and used inline comments to make prettier ignore the blocks that break (which in most cases actually ended up being the whole file due to missing content).

Because i was looking at biome (which doesn't support markdown) a few days ago i thought it may be a good idea to look into an alterantive formatter for the mdx files (since prettier probably won't support mdx this century prettier/prettier#12209 ) and really the only thing there is, is remark (with remark-lint etc). It indeed can format what prettier struggles with but it fails in other places. I don't have the time nor energy (nor the knowledge) to create our own remark plugin(s) for that so i scrapped the remark approach too.

The workflow isn't failing anymore so i'm closing this.

@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ✅ Done in Documentation Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Does it fix inaccurate content or fix a bug? good first issue Is it good for beginners to take up?
Projects
Status: ✅ Done
Development

No branches or pull requests

2 participants