-
-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error running coverage report, traced back to tao
dependency core-video-sys
#270
Comments
What a great finding. Thankyou so much for digging in! Now what to do about it is the next question. Sometimes we adopt packages (either through forking and publishing under a similar name but in the hopes the original author picks it back up) or we accept the transfer and become maintainers. The latter is more work, because we have to apply our own CI and licenses etc. In either case, it's worthwhile tracking down the original authors and asking them how they would like to proceed. If they don't respond in a couple weeks then we can assume its been abandoned, and we are unlikely to receive a proper repo transfer. In the meantime, we can prepare the fork(s). Would you consider doing this on your own and then transferring to our github org? And reat assured, we would happily welcome you as a maintainer. :) |
@nothingismagick I would love to help out in any way, this project is so useful to me. I will create a fork of that fixed version of |
|
I am not sure what you mean, I still do see it listed in |
Ah sorry, silly me just run cargo tree on different platform. |
This should be fixed by #274. Let me know if it's still an issue. |
thanks @wusyong. I have a couple of notes. On looking at the source on |
Hey guys, so I was having some issues compiling sometimes, especially when building my app in order to run
grcov
, my app was having some trouble on macOS, getting the following error message:I did some digging and found this issue - which mentioned that the error was related to an older version of
core-foundation-rs
.I did a little more digging and found that
tao
depends oncore-video-sys
, which in turn depends on that older version ofcore-foundation-rs
. Thatcore-video-sys
crate seems to be abandoned. Someone graciously cleaned up the code and dependencies and submitted a pull request but this has not been merged for nearly 5 months.While investigating, I was hoping that the PR would fix the issue, and it did in fact. In order to test it I cloned
tao
, and added a patch statement to theCargo.toml
to use the PR branch. I then added patch statement towry
to reference the localtao
copy with the patch statement in itsCargo.toml
, and so on and so forth fortauri-runtime-wry
andtauri
, and finally my application.I was wondering how/if the team could address this - perhaps submodule the crate or something? From my understanding crates aren't allowed to be published with git dependencies, but are there any other solutions?
Thanks for all your work, and as always, please let me know how I can help!
The text was updated successfully, but these errors were encountered: