feat(sql): allow open absolute sqlite path #1380
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thewh1teagle
changed the title
|
As mentioned in #1441 (comment) i plan to make some larger changes and the connection logic will be part of it. Are you okay with me creating a combined PR and add you as a co-author? (github should attribute you basically the same as if it's your pr) |
|
@FabianLars |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the sql plugin in plugins-workspace for v2. It now allows opening SQLite files from any absolute path. If the path is not absolute, it still defaults to opening files relative to the app directory.
Examples of possible connection strings: