Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat][notification] make struct Notification public #2161

Open
WSH032 opened this issue Dec 7, 2024 · 1 comment
Open

[feat][notification] make struct Notification public #2161

WSH032 opened this issue Dec 7, 2024 · 1 comment
Labels
plugin: notification

Comments

@WSH032
Copy link

WSH032 commented Dec 7, 2024

It seems that struct Notification is currently sealed. Is this intentional? If not, could it be public?

I need to wrap struct Notification to implement pyo3 bindings. Here is an example of wrapping NotificationBuilder.
@FabianLars
Copy link
Member

No it's not intentional. Same thing with the Dialog plugin a few days ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
plugin: notification
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@FabianLars @WSH032