Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat][nsis] clean updater files from temp #2132

Open
thewh1teagle opened this issue Dec 3, 2024 · 3 comments
Open

[feat][nsis] clean updater files from temp #2132

thewh1teagle opened this issue Dec 3, 2024 · 3 comments
Labels

Comments

@thewh1teagle
Copy link
Contributor

thewh1teagle commented Dec 3, 2024

Describe the problem

Currently when updating tauri app in Windows 11 the updater files kept in %tmp%. eg. C:\Users%username%\AppData\Local\Temp\vibe-2.6.8-updater-VNnPSJ

thewh1teagle/vibe#410 (comment)

Describe the solution you'd like

Clean the files when the app start automatically in updater, or after updating.

Alternatives considered

No response

Additional context

No response

@Legend-Master Legend-Master transferred this issue from tauri-apps/tauri Dec 4, 2024
@Legend-Master
Copy link
Contributor

Legend-Master commented Dec 4, 2024

Maybe we can mark the updater file and folder with MOVEFILE_DELAY_UNTIL_REBOOT so it gets removed on next boot like what NSIS uninstaller does? Maybe not, MOVEFILE_DELAY_UNTIL_REBOOT requires admin right

@thewh1teagle
Copy link
Contributor Author

thewh1teagle commented Dec 4, 2024

Maybe we can mark the updater file and folder with MOVEFILE_DELAY_UNTIL_REBOOT so it gets removed on next boot like what NSIS uninstaller does? Maybe not, MOVEFILE_DELAY_UNTIL_REBOOT requires admin right

Updater plugin can check if the path exists on startup and delete them on all platforms
By the way it happened with NSIS

@Legend-Master
Copy link
Contributor

It's quite tricky to make self deleting executables on Windows, so probably storing the updater's path somewhere and delete them with the updater plugin on next launch would be a good idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants