Skip to content

Commit 931d31a

Browse files
committed
deps: V8: cherry-pick 412ac52d8246
Original commit message: [bigint] Fix possibly-uninitialized leading digit on right shift (cherry picked from commit e82a3b4d47a93ab64f07d8c03e3cd17b6b961c3f) (cherry picked from commit 1162c460dee4218abd798b51b88926aef5c8bd61) No-Try: true No-Presubmit: true No-Tree-Checks: true Fixed: chromium:1151890 Change-Id: I26f5c76494a9ff3f5a141f381e1c9a543e368571 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2561618 Auto-Submit: Jakob Kummerow <[email protected]> Commit-Queue: Georg Neis <[email protected]> Reviewed-by: Georg Neis <[email protected]> Cr-Original-Original-Commit-Position: refs/heads/master@{#71422} Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2565245 Reviewed-by: Jakob Kummerow <[email protected]> Cr-Original-Commit-Position: refs/branch-heads/8.7@{nodejs#57} Cr-Original-Branched-From: 0d81cd72688512abcbe1601015baee390c484a6a-refs/heads/8.7.220@{#1} Cr-Original-Branched-From: 942c2ef85caef00fcf02517d049f05e9a3d4b440-refs/heads/master@{#70196} Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2624611 Commit-Queue: Victor-Gabriel Savu <[email protected]> Cr-Commit-Position: refs/branch-heads/8.6@{nodejs#54} Cr-Branched-From: a64aed2333abf49e494d2a5ce24bbd14fff19f60-refs/heads/8.6.395@{#1} Cr-Branched-From: a626bc036236c9bf92ac7b87dc40c9e538b087e3-refs/heads/master@{#69472} Refs: v8/v8@412ac52 PR-URL: nodejs#38275 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Shelley Vohr <[email protected]>
1 parent e99e456 commit 931d31a

File tree

3 files changed

+14
-1
lines changed

3 files changed

+14
-1
lines changed

common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Reset this number to 0 on major V8 upgrades.
3838
# Increment by one for each non-official patch applied to deps/v8.
39-
'v8_embedder_string': '-node.39',
39+
'v8_embedder_string': '-node.40',
4040

4141
##### V8 defaults for Node.js #####
4242

deps/v8/src/objects/bigint.cc

+2
Original file line numberDiff line numberDiff line change
@@ -1862,6 +1862,8 @@ Handle<BigInt> MutableBigInt::RightShiftByAbsolute(Isolate* isolate,
18621862
DCHECK_LE(result_length, length);
18631863
Handle<MutableBigInt> result = New(isolate, result_length).ToHandleChecked();
18641864
if (bits_shift == 0) {
1865+
// Zero out any overflow digit (see "rounding_can_overflow" above).
1866+
result->set_digit(result_length - 1, 0);
18651867
for (int i = digit_shift; i < length; i++) {
18661868
result->set_digit(i - digit_shift, x->digit(i));
18671869
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
// Copyright 2020 the V8 project authors. All rights reserved.
2+
// Use of this source code is governed by a BSD-style license that can be
3+
// found in the LICENSE file.
4+
5+
// Flags: --allow-natives-syntax
6+
7+
for (let i = 0, j = 0; i < 10; ++i) {
8+
let x = (-0xffffffffffffffff_ffffffffffffffffn >> 0x40n);
9+
assertEquals(-0x10000000000000000n, x);
10+
%SimulateNewspaceFull();
11+
}

0 commit comments

Comments
 (0)