From 651088c3e6b6399a3e656e397c3845b970ad7903 Mon Sep 17 00:00:00 2001 From: Milad Farazmand Date: Tue, 2 Jun 2020 18:06:14 +0000 Subject: [PATCH] deps: V8: cherry-pick 4e1bf2bc92bd MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Original commit message: Skip InterpreterWithNativeStack on jitless mode As discussed under https://crrev.com/c/1981505, Test requires an executable CODE_SPACE and is thus incompatible with jitless mode. Change-Id: Icddad50a3484f0cfc5fb4abd7175058d50bc06d3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2193911 Reviewed-by: Jakob Gruber Commit-Queue: Jakob Gruber Cr-Commit-Position: refs/heads/master@{#67726} Refs: https://github.com/v8/v8/commit/4e1bf2bc92bd8560353ba2af2f171045bbecb7c7 PR-URL: https://github.com/nodejs/node/pull/33702 Reviewed-By: Richard Lau Reviewed-By: Michaël Zasso Reviewed-By: Michael Dawson --- common.gypi | 2 +- deps/v8/test/cctest/cctest.status | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/common.gypi b/common.gypi index 76a55b7b628f72..2c32f9e6c3c3ea 100644 --- a/common.gypi +++ b/common.gypi @@ -36,7 +36,7 @@ # Reset this number to 0 on major V8 upgrades. # Increment by one for each non-official patch applied to deps/v8. - 'v8_embedder_string': '-node.18', + 'v8_embedder_string': '-node.19', ##### V8 defaults for Node.js ##### diff --git a/deps/v8/test/cctest/cctest.status b/deps/v8/test/cctest/cctest.status index 444ec9d8eccba8..5862e3410869be 100644 --- a/deps/v8/test/cctest/cctest.status +++ b/deps/v8/test/cctest/cctest.status @@ -601,6 +601,7 @@ 'test-log/LogInterpretedFramesNativeStack': [SKIP], 'test-log/LogInterpretedFramesNativeStackWithSerialization': [SKIP], 'test-serialize/CodeSerializerOnePlusOneWithInterpretedFramesNativeStack': [SKIP], + 'test-interpreter/InterpreterWithNativeStack': [SKIP], # Crashes on native arm. 'test-macro-assembler-arm/ExtractLane': [PASS, ['arch == arm and not simulator_run', SKIP]],