Skip to content

Commit

Permalink
lib: remove usage of require('util')
Browse files Browse the repository at this point in the history
Remove usage of public require('util') in
`internal/child_process`.

Refs: nodejs#26546

PR-URL: nodejs#26773
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
  • Loading branch information
dnlup authored and targos committed Mar 27, 2019
1 parent d41254d commit 225b249
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions lib/internal/child_process.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ const EventEmitter = require('events');
const net = require('net');
const dgram = require('dgram');
const util = require('util');
const inspect = require('internal/util/inspect').inspect;
const assert = require('internal/assert');

const { Process } = internalBinding('process_wrap');
Expand Down Expand Up @@ -887,7 +888,7 @@ function _validateStdio(stdio, sync) {
throw new ERR_INVALID_OPT_VALUE('stdio', stdio);
}
} else if (!Array.isArray(stdio)) {
throw new ERR_INVALID_OPT_VALUE('stdio', util.inspect(stdio));
throw new ERR_INVALID_OPT_VALUE('stdio', inspect(stdio));
}

// At least 3 stdio will be created
Expand Down Expand Up @@ -967,12 +968,12 @@ function _validateStdio(stdio, sync) {
} else if (isArrayBufferView(stdio) || typeof stdio === 'string') {
if (!sync) {
cleanup();
throw new ERR_INVALID_SYNC_FORK_INPUT(util.inspect(stdio));
throw new ERR_INVALID_SYNC_FORK_INPUT(inspect(stdio));
}
} else {
// Cleanup
cleanup();
throw new ERR_INVALID_OPT_VALUE('stdio', util.inspect(stdio));
throw new ERR_INVALID_OPT_VALUE('stdio', inspect(stdio));
}

return acc;
Expand Down

0 comments on commit 225b249

Please sign in to comment.