-
-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Graal optimizations may break uberjar running #378
Comments
@TuggyNE Hi there, thanks for the report! Requesting a bit more info please-
Thanks! |
https://github.com/fzakaria/slf4j-timbre
Yes, but it doesn't help. (I did confirm it's not architecture or OS-dependent, though.)
Nope, totally routine build. (I don't actually use GraalVM NI for anything on this project, it's just a plain uberjar.)
You're welcome, and thanks for the quick reply! |
Can you share the version of Timbre that were you upgrading from? (May be helpful to pinpoint when an issue was introduced). From your stacktrace, it looks to me like the problem might be with the appender, thought it's not immediately obvious to me what change/s might have caused trouble.
That change only affects unit tests, so I don't believe should affect your build. I'd recommend opening an issue with slf4j-timbre. That project's maintainer can maybe more easily identify the problem from the stacktrace. If it turns out there was some kind of regression on Timbre's side, or if there's something I can do from Timbre's side to workaround the problem - I'll of course get right on it. In the meantime am hoping they might be able to provide some guidance. |
Relatedly, have also just opened fzakaria/slf4j-timbre#71 |
Thanks for bringing this up @TuggyNE! Am I to understand that slf4j-timbre previously worked correctly under GraalVM? (I remember someone trying this out a while ago, but I don't recall the outcome.) I'll aim to incorporate GraalVM into slf4j-timbre's integration tests so we can figure out any problems and avoid regressions. |
Just an update to mention that I'm planning a major Timbre update around Jul-Aug that will include out-the-box SLF4J integration and that will be covered by Timbre's own test suite. |
v6.6.0-RC1 is out now, with built-in SLF4J support 👍 Closing |
I recently upgraded Timbre and Tufte (as I use
lein-ancient
as part of my release scripting) and was surprised to discover a runtime failure on deployment. Local running is fine, uberjar building is fine, but on the server I get a stack trace that looks like this:It looks like it could be a subtle unexpected side effect of recent changes to optimize GraalVM builds.
It's possible that this only shows up when using the SLF4J adapter for Timbre, which is third-party. I don't have a great way to test without that currently, but I could work up a more minimal complete example if needed.
The text was updated successfully, but these errors were encountered: