Skip to content

Commit e6cdf99

Browse files
committed
[mod] Refactor, improve logging
1 parent 67df9b7 commit e6cdf99

File tree

3 files changed

+202
-122
lines changed

3 files changed

+202
-122
lines changed

example-project/src/example/client.cljs

+9-6
Original file line numberDiff line numberDiff line change
@@ -15,15 +15,18 @@
1515
(:require-macros
1616
[cljs.core.async.macros :as asyncm :refer [go go-loop]]))
1717

18-
;; (timbre/set-level! :trace) ; Uncomment for more logging
18+
;;;; Logging config
19+
20+
(sente/set-min-log-level! :info) ; Min log level for internal Sente namespaces
21+
(timbre/set-ns-min-level! :info) ; Min log level for this namespace
1922

2023
;;;; Util for logging output to on-screen console
2124

2225
(def output-el (.getElementById js/document "output"))
2326
(defn ->output! [fmt & args]
2427
(let [msg (apply encore/format fmt args)]
25-
(timbre/debugf "->output: %s" msg)
26-
(aset output-el "value" (str "" (.-value output-el) "\n" msg))
28+
;; (timbre/tracef "->output: %s" msg)
29+
(aset output-el "value" (str (.-value output-el) "\n" msg))
2730
(aset output-el "scrollTop" (.-scrollHeight output-el))))
2831

2932
(->output! "ClojureScript appears to have loaded correctly.")
@@ -140,13 +143,13 @@
140143
(when-let [target-el (.getElementById js/document "btn5")]
141144
(.addEventListener target-el "click"
142145
(fn [ev]
143-
(->output! "Disconnecting")
146+
(->output! "Disconnecting...\n\n")
144147
(sente/chsk-disconnect! chsk))))
145148

146149
(when-let [target-el (.getElementById js/document "btn6")]
147150
(.addEventListener target-el "click"
148151
(fn [ev]
149-
(->output! "Reconnecting")
152+
(->output! "Reconnecting...\n\n")
150153
(sente/chsk-reconnect! chsk))))
151154

152155
(when-let [target-el (.getElementById js/document "btn-login")]
@@ -156,7 +159,7 @@
156159
(if (str/blank? user-id)
157160
(js/alert "Please enter a user-id first")
158161
(do
159-
(->output! "Logging in with user-id %s" user-id)
162+
(->output! "Logging in with user-id %s...\n\n" user-id)
160163

161164
;;; Use any login procedure you'd like. Here we'll trigger an Ajax
162165
;;; POST request that resets our server-side session. Then we ask

example-project/src/example/server.clj

+4-2
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,10 @@
3838
;; Optional, for Transit encoding:
3939
[taoensso.sente.packers.transit :as sente-transit]))
4040

41-
;; (timbre/set-level! :trace) ; Uncomment for more logging
42-
;; (reset! sente/debug-mode?_ true) ; Uncomment for extra debug info
41+
;;;; Logging config
42+
43+
(sente/set-min-log-level! :info) ; Min log level for internal Sente namespaces
44+
(timbre/set-ns-min-level! :info) ; Min log level for this namespace
4345

4446
;;;; Define our Sente channel socket (chsk) server
4547

0 commit comments

Comments
 (0)