From ce93e0a18b8d968e3d65d0077e3fe4c2b4754a12 Mon Sep 17 00:00:00 2001
From: Peter Taoussanis <peter@taoensso.com>
Date: Wed, 18 Sep 2024 13:02:47 +0200
Subject: [PATCH] [v4] Disable issue-83 workaroud by default

---
 src/taoensso/carmine_v4.clj             | 16 +++++++++-------
 test/taoensso/carmine_v4/tests/resp.clj |  3 ++-
 2 files changed, 11 insertions(+), 8 deletions(-)

diff --git a/src/taoensso/carmine_v4.clj b/src/taoensso/carmine_v4.clj
index d619500..1004685 100644
--- a/src/taoensso/carmine_v4.clj
+++ b/src/taoensso/carmine_v4.clj
@@ -195,15 +195,17 @@
 
 (def ^:dynamic *issue-83-workaround?*
   "TODO Docstring incl. env config.
-  A bug in Carmine v2.6.0 to v2.6.1 (2014-04-01 to 2014-05-01)
-  caused Nippy blobs to be marked incorrectly (with `ba-bin` instead
-  of `ba-npy`), Ref. <https://github.com/ptaoussanis/carmine/issues/83>
+  Only relevant if `*auto-thaw?` is true.
 
-  This should be kept true (the default) if there's a chance you might
-  read any data written by Carmine < v2.6.1 (2014-05-01).
+  A bug in Carmine v2.6.0 to v2.6.1 (2014-04-01 to 2014-05-01) caused Nippy blobs
+  to be marked incorrectly, Ref. <https://github.com/ptaoussanis/carmine/issues/83>
 
-  Only relevant if `*auto-thaw?` is true."
-  (enc/get-env {:as :bool, :default true}
+  When enabled, this workaround will cause Carmine to automatically try thaw any
+  reply byte data that starts with a valid Nippy header.
+
+  Enable iff you might read data written by Carmine < v2.6.1 (2014-05-01).
+  Disabled by default."
+  (enc/get-env {:as :bool, :default false}
     :taoensso.carmine.issue-83-workaround))
 
 (def ^:dynamic *conn-cbs*
diff --git a/test/taoensso/carmine_v4/tests/resp.clj b/test/taoensso/carmine_v4/tests/resp.clj
index 77be1fc..047bf21 100644
--- a/test/taoensso/carmine_v4/tests/resp.clj
+++ b/test/taoensso/carmine_v4/tests/resp.clj
@@ -44,7 +44,8 @@
    (is (= (test-blob-?marker "\u0000_more")    [:nil "more"]))
    (is (= (test-blob-?marker "\u0000>more")    [:npy "more"]))
    (is (= (test-blob-?marker "\u0000<more")    [:bin "more"]))
-   (is (= (test-blob-?marker "\u0000<NPYmore") [:npy "NPYmore"]))
+   (binding [core/*issue-83-workaround?* true ] (is (= (test-blob-?marker "\u0000<NPYmore") [:npy "NPYmore"])))
+   (binding [core/*issue-83-workaround?* false] (is (= (test-blob-?marker "\u0000<NPYmore") [:bin "NPYmore"])))
    (is (= (test-blob-?marker "\u0000<NPmore")  [:bin "NPmore"]))
    (is (= (test-blob-?marker "\u0000<Nmore")   [:bin "Nmore"]))])