Skip to content

Commit 9d77e2a

Browse files
committed
test: fix integration test in pingcap/parser#808
1 parent ddcc89d commit 9d77e2a

File tree

5 files changed

+10
-7
lines changed

5 files changed

+10
-7
lines changed

ddl/db_integration_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -762,7 +762,7 @@ func (s *testIntegrationSuite4) TestChangingTableCharset(c *C) {
762762
tk.MustExec("USE test")
763763
tk.MustExec("create table t(a char(10)) charset latin1 collate latin1_bin")
764764

765-
tk.MustGetErrCode("alter table t charset gbk", errno.ErrUnknownCharacterSet)
765+
tk.MustGetErrCode("alter table t charset unknown_cs", errno.ErrUnknownCharacterSet)
766766
tk.MustGetErrCode("alter table t charset ''", errno.ErrUnknownCharacterSet)
767767

768768
tk.MustGetErrCode("alter table t charset utf8mb4 collate '' collate utf8mb4_bin;", errno.ErrUnknownCollation)

executor/executor_test.go

+3-2
Original file line numberDiff line numberDiff line change
@@ -252,8 +252,9 @@ func (s *testSuiteP1) TestShow(c *C) {
252252
"utf8 UTF-8 Unicode utf8_bin 3",
253253
"utf8mb4 UTF-8 Unicode utf8mb4_bin 4",
254254
"ascii US ASCII ascii_bin 1",
255-
"latin1 Latin1 latin1_bin 1",
256-
"binary binary binary 1"))
255+
"latin1 cp1252 West European latin1_bin 1",
256+
"binary Binary pseudo charset binary 1",
257+
"gbk GBK Simplified Chinese gbk_chinese_ci 1"))
257258
c.Assert(len(tk.MustQuery("show master status").Rows()), Equals, 1)
258259
tk.MustQuery("show create database test_show").Check(testkit.Rows("test_show CREATE DATABASE `test_show` /*!40100 DEFAULT CHARACTER SET utf8mb4 */"))
259260
tk.MustQuery("show privileges").Check(testkit.Rows("Alter Tables To alter the table",

executor/infoschema_reader_test.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -221,12 +221,12 @@ func (s *testInfoschemaTableSuite) TestCharacterSetCollations(c *C) {
221221

222222
// The description column is not important
223223
tk.MustQuery("SELECT default_collate_name, maxlen FROM information_schema.character_sets ORDER BY character_set_name").Check(
224-
testkit.Rows("ascii_bin 1", "binary 1", "latin1_bin 1", "utf8_bin 3", "utf8mb4_bin 4"))
224+
testkit.Rows("ascii_bin 1", "binary 1", "gbk_chinese_ci 1", "latin1_bin 1", "utf8_bin 3", "utf8mb4_bin 4"))
225225

226226
// The is_default column is not important
227227
// but the id's are used by client libraries and must be stable
228228
tk.MustQuery("SELECT character_set_name, id, sortlen FROM information_schema.collations ORDER BY collation_name").Check(
229-
testkit.Rows("ascii 65 1", "binary 63 1", "latin1 47 1", "utf8 83 1", "utf8mb4 46 1"))
229+
testkit.Rows("ascii 65 1", "binary 63 1", "gbk 28 1", "latin1 47 1", "utf8 83 1", "utf8mb4 46 1"))
230230

231231
tk.MustQuery("select * from information_schema.COLLATION_CHARACTER_SET_APPLICABILITY where COLLATION_NAME='utf8mb4_bin';").Check(
232232
testkit.Rows("utf8mb4_bin utf8mb4"))

go.mod

+2
Original file line numberDiff line numberDiff line change
@@ -77,3 +77,5 @@ require (
7777
)
7878

7979
go 1.13
80+
81+
replace github.com/pingcap/parser => github.com/spongedu/parser v0.0.0-20200413061525-2b6c2eb15c23

go.sum

+2-2
Original file line numberDiff line numberDiff line change
@@ -269,8 +269,6 @@ github.com/pingcap/kvproto v0.0.0-20200409034505-a5af800ca2ef/go.mod h1:IOdRDPLy
269269
github.com/pingcap/log v0.0.0-20191012051959-b742a5d432e9/go.mod h1:4rbK1p9ILyIfb6hU7OG2CiWSqMXnp3JMbiaVJ6mvoY8=
270270
github.com/pingcap/log v0.0.0-20200117041106-d28c14d3b1cd h1:CV3VsP3Z02MVtdpTMfEgRJ4T9NGgGTxdHpJerent7rM=
271271
github.com/pingcap/log v0.0.0-20200117041106-d28c14d3b1cd/go.mod h1:4rbK1p9ILyIfb6hU7OG2CiWSqMXnp3JMbiaVJ6mvoY8=
272-
github.com/pingcap/parser v0.0.0-20200413043052-ef80f4de418c h1:8guNDWaL4d4Nsl+ptn2Z6ND/twrPtVYqy4+HxwSFPt8=
273-
github.com/pingcap/parser v0.0.0-20200413043052-ef80f4de418c/go.mod h1:9v0Edh8IbgjGYW2ArJr19E+bvL8zKahsFp+ixWeId+4=
274272
github.com/pingcap/pd/v4 v4.0.0-beta.1.0.20200305072537-61d9f9cc35d3 h1:Yrp99FnjHAEuDrSBql2l0IqCtJX7KwJbTsD5hIArkvk=
275273
github.com/pingcap/pd/v4 v4.0.0-beta.1.0.20200305072537-61d9f9cc35d3/go.mod h1:25GfNw6+Jcr9kca5rtmTb4gKCJ4jOpow2zV2S9Dgafs=
276274
github.com/pingcap/sysutil v0.0.0-20200206130906-2bfa6dc40bcd/go.mod h1:EB/852NMQ+aRKioCpToQ94Wl7fktV+FNnxf3CX/TTXI=
@@ -330,6 +328,8 @@ github.com/spaolacci/murmur3 v0.0.0-20180118202830-f09979ecbc72/go.mod h1:JwIasO
330328
github.com/spf13/cobra v0.0.3/go.mod h1:1l0Ry5zgKvJasoi3XT1TypsSe7PqH0Sj9dhYf7v3XqQ=
331329
github.com/spf13/pflag v1.0.1 h1:aCvUg6QPl3ibpQUxyLkrEkCHtPqYJL4x9AuhqVqFis4=
332330
github.com/spf13/pflag v1.0.1/go.mod h1:DYY7MBk1bdzusC3SYhjObp+wFpr4gzcvqqNjLnInEg4=
331+
github.com/spongedu/parser v0.0.0-20200413061525-2b6c2eb15c23 h1:pRJhudJDUx4oCOm3VcZ5+6T05xOvNdayJrT23T/EX+Y=
332+
github.com/spongedu/parser v0.0.0-20200413061525-2b6c2eb15c23/go.mod h1:9v0Edh8IbgjGYW2ArJr19E+bvL8zKahsFp+ixWeId+4=
333333
github.com/stretchr/objx v0.1.0/go.mod h1:HFkY916IF+rwdDfMAkV7OtwuqBVzrE8GR6GFx+wExME=
334334
github.com/stretchr/objx v0.1.1/go.mod h1:HFkY916IF+rwdDfMAkV7OtwuqBVzrE8GR6GFx+wExME=
335335
github.com/stretchr/objx v0.2.0/go.mod h1:qt09Ya8vawLte6SNmTgCsAVtYtaKzEcn8ATUoHMkEqE=

0 commit comments

Comments
 (0)