Generator: method call conflicts

[tamimattafi]

Problem

The current generator uses parameters to generate method names for queries, and doesn't take into account the query itself. This creates conflicts for situations where parameters and return types are the same, but queries are different.

This can be reproduced inside the sample, here's an example from UserDao:

@Query("SELECT * FROM UserEntity WHERE sampleAge < 18")
suspend fun getUnderageUsers(): List<UserEntity>

@Query("SELECT * FROM UserEntity WHERE sampleAge >= 18")
suspend fun getAdultUsers(): List<UserEntity>

@Query("SELECT * FROM UserEntity")
suspend fun getEntitiesReactive(): Flow<List<UserEntity>>

The generated code looks like this:

override suspend fun getUnderageUsers(): List<UserEntity> = transactionWithResult {
    queries.queryUserEntityByNoParameters().awaitAsListIO()
}

override suspend fun getAdultUsers(): List<UserEntity> = transactionWithResult {
    queries.queryUserEntityByNoParameters().awaitAsListIO()
}

override suspend fun getEntitiesReactive(): Flow<List<UserEntity>> =
    queries.queryUserEntityByNoParameters().asFlowIOList()

As you already noticed, all three methods call the same queryUserEntityByNoParameters, even if they have different queries.
The generated queryUserEntityByNoParameters looks like this:

public fun queryUserEntityByNoParameters(): Query<UserEntity> = object :
      Query<UserEntity>(comAttafitamimKabinLocalEntitiesUserUserEntityKabinMapper::map) {
    override fun addListener(listener: Query.Listener) {
      driver.addListener(
      "UserEntity",
      listener = listener
      )
    }

    override fun removeListener(listener: Query.Listener) {
      driver.removeListener(
      "UserEntity",
      listener = listener
      )
    }

    override fun <R> execute(mapper: SqlCursor.() -> QueryResult<R>): QueryResult<R> {
      val kabinQuery = """SELECT * FROM UserEntity WHERE sampleAge < 18"""
      val kabinParametersCount = 0
      val result = driver.executeQuery(
              -1060829723,
              kabinQuery,
              mapper,
              kabinParametersCount
          )
      return result
    }
}

As we see, it's only related to getUnderageUsers, the other two queries were lost.

Solution

Take into account the actual query when generating method names, using some kind of ID