Skip to content

Do not migrate variant = 'outline' during upgrades #18922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 12, 2025
+16 −0
Merged

Do not migrate variant = 'outline' during upgrades #18922

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3eb4085
add failing tests
RobinMalfait Sep 12, 2025
3ce5447
do not migrate `variant = 'outline'` to `variant = 'outline-solid'`
RobinMalfait Sep 12, 2025
b0b0ffc
update changelog
RobinMalfait Sep 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Do not generate `grid-column` utilities when configuring `grid-column-start` or `grid-column-end` ([#18907](https://github.com/tailwindlabs/tailwindcss/pull/18907))
- Do not generate `grid-row` utilities when configuring `grid-row-start` or `grid-row-end` ([#18907](https://github.com/tailwindlabs/tailwindcss/pull/18907))
- Prevent duplicate CSS when overwriting a static utility with a theme key ([#18056](https://github.com/tailwindlabs/tailwindcss/pull/18056))
- Do not migrate `variant = 'outline'` during upgrades ([#18922](https://github.com/tailwindlabs/tailwindcss/pull/18922))

## [4.1.13] - 2025-09-03

Expand Down
12 changes: 12 additions & 0 deletions packages/@tailwindcss-upgrade/src/codemods/template/is-safe-migration.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,18 @@ describe('is-safe-migration', async () => {

[`function foo(blur, foo)`, 'blur'],
[`function foo(blur,foo)`, 'blur'],

// shadcn/ui variants
[`<Button variant="outline" />`, 'outline'],
[`<Button variant='outline' />`, 'outline'],
[`<Button variant={"outline"} />`, 'outline'],
[`<Button variant={'outline'} />`, 'outline'],
[`function Button({ variant = "outline" }) {}`, 'outline'],
[`function Button({ variant = 'outline' }) {}`, 'outline'],
[`function Button({ variant="outline" }) {}`, 'outline'],
[`function Button({ variant='outline' }) {}`, 'outline'],
[`Button({ variant: "outline" })`, 'outline'],
[`Button({ variant: 'outline' })`, 'outline'],
])('does not replace classes in invalid positions #%#', async (example, candidate) => {
expect(
await migrateCandidate(designSystem, {}, candidate, {
Expand Down
3 changes: 3 additions & 0 deletions packages/@tailwindcss-upgrade/src/codemods/template/is-safe-migration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ const CONDITIONAL_TEMPLATE_SYNTAX = [
/x-if=['"]$/,
/x-show=['"]$/,
/wire:[^\s]*?$/,

// shadcn/ui variants
/variant\s*[:=]\s*\{?['"`]$/,
]
const NEXT_PLACEHOLDER_PROP = /placeholder=\{?['"`]$/
const VUE_3_EMIT = /\b\$?emit\(['"`]$/
Expand Down