Skip to content

Conversation

@philipp-spiess
Copy link
Member

@philipp-spiess philipp-spiess commented Feb 27, 2025

Closes #16829

We were only adding keyframes used in variables starting with --animate (without adding a potential prefix).

Test plan

  • Added a unit test

@philipp-spiess philipp-spiess marked this pull request as ready for review February 27, 2025 14:31
@philipp-spiess philipp-spiess requested a review from a team as a code owner February 27, 2025 14:31
@philipp-spiess philipp-spiess merged commit 66ef77c into main Feb 27, 2025
5 checks passed
@philipp-spiess philipp-spiess deleted the fix/keyframes branch February 27, 2025 16:35
@Atydin
Copy link

Atydin commented Mar 6, 2025

Still have issues with animations not working with prefix.

@philipp-spiess
Copy link
Member Author

@Atydin Mind creating a new issue and attaching a reproduction setup?

@sami616
Copy link

sami616 commented Mar 9, 2025

same here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Animations don't work with prefix

5 participants