Skip to content

Conversation

@adamwathan
Copy link
Member

Resolves #14440.

This PR fixes an issue where registering a custom inset-shadow-* utility value in your theme like this:

@theme {
  --inset-shadow-potato: inset 0px 2px 6px #7a4724;
}

…mistakenly generates both an inset-shadow-* and inset-* utility with that value:

.inset-shadow-potato {
  inset: inset 0px 2px 6px #7a4724;
}

.inset-shadow-potato {
  box-shadow: inset 0px 2px 6px #7a4724;
}

This replaces #14445 which turns out to not be the ideal solution.

Now we just explicitly ignore variables like --inset-shadow-* and --inset-ring-* in the inset handler. Kind of a gross patch but I can live with it because the whole existence of the --inset-* key is kind of a backwards compatibility thing anyways.

@adamwathan adamwathan changed the title Explicitly igore --inset-shadow and --inset-ring variables in inset handler Explicitly ignore --inset-shadow and --inset-ring variables in inset handler Sep 18, 2024
@philipp-spiess philipp-spiess force-pushed the fix/issue-14440-attempt-2 branch from 9afa300 to 726fb42 Compare September 18, 2024 10:00
@adamwathan adamwathan merged commit c817453 into next Sep 18, 2024
@adamwathan adamwathan deleted the fix/issue-14440-attempt-2 branch September 18, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug in v4 with --inset-shadow-* generating inset position rule

3 participants