Show color decorators when utility has an opacity modifier in v4 #969
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecrypticace
force-pushed
the
feat/remove-color-mix
branch
from
096fc11 to
fe8f97d
Compare
RobinMalfait
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use
color-mixto apply alpha values to colors — because of this we don't show color decorators for any utility with an opacity modifier in a v4 project.We remove the wrapping
color-mixand apply the alpha value to the color so we end up parsing a valid color string into their separate r, g, b, and a channels.Also made sure that gradient utilities show their color swatches — they were being excluded because we were looking at declarations inside
@propertyand then throwing stuff out.