From f77eb7cc2ea92053b6a199f67c62b0db319710c7 Mon Sep 17 00:00:00 2001
From: Mario Minardi <mario@tailscale.com>
Date: Thu, 12 Sep 2024 16:11:36 -0600
Subject: [PATCH] [tailscale] .github: stop using upload-release-asset action

Change to use `action-gh-release` instead of `upload-release-asset` as
the repo for `upload-release-asset` is in public archive and recommends
swapping over to `action-gh-release`.

Updates https://github.com/tailscale/go/issues/47

Signed-off-by: Mario Minardi <mario@tailscale.com>
---
 .github/workflows/build.yml | 38 ++++++++++---------------------------
 1 file changed, 10 insertions(+), 28 deletions(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 97c17a64fb35b7..b51c60e325e330 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -73,26 +73,7 @@ jobs:
         name: ${{ matrix.GOOS }}-${{ matrix.GOARCH }}
         path: ${{ env.artifacts_path }}/${{ matrix.GOOS }}-${{ matrix.GOARCH }}.tar.gz
 
-  create_release:
-    runs-on: ubuntu-24.04
-    if: contains(fromJSON('["push", "workflow_dispatch"]'), github.event_name)
-    needs: [test, build_release]
-    outputs:
-      url: ${{ steps.create_release.outputs.upload_url }}
-    steps:
-    - name: create release
-      id: create_release
-      uses: actions/create-release@v1
-      env:
-        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-      with:
-        # Release name can't be the same as tag name, sigh
-        tag_name: build-${{ inputs.ref || github.sha }}
-        release_name: ${{ inputs.ref || github.sha }}
-        draft: false
-        prerelease: true
-
-  upload_release:
+  release:
     strategy:
       matrix:
         GOOS: ["linux", "darwin", "windows"]
@@ -102,21 +83,22 @@ jobs:
             GOARCH: arm64
     runs-on: ubuntu-24.04
     if: contains(fromJSON('["push", "workflow_dispatch"]'), github.event_name)
-    needs: [create_release]
+    needs: [test, build_release]
     steps:
     - name: download artifact
       uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.8
       with:
         name: ${{ matrix.GOOS }}-${{ matrix.GOARCH }}
     - name: upload artifact
-      uses: actions/upload-release-asset@v1
-      env:
-        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+      uses: softprops/action-gh-release@c062e08bd532815e2082a85e87e3ef29c3e6d191 # v2.0.8
       with:
-        upload_url: ${{ needs.create_release.outputs.url }}
-        asset_path: ${{ matrix.GOOS }}-${{ matrix.GOARCH }}.tar.gz
-        asset_name: ${{ matrix.GOOS }}-${{ matrix.GOARCH }}.tar.gz
-        asset_content_type: application/gzip
+        # Release name can't be the same as tag name, sigh
+        tag_name: build-${{ inputs.ref || github.sha }}
+        name: ${{ inputs.ref || github.sha }}
+        draft: false
+        prerelease: true
+        files: ${{ matrix.GOOS }}-${{ matrix.GOARCH }}.tar.gz
+        token: ${{ secrets.GITHUB_TOKEN }}
 
   clean_old:
     runs-on: ubuntu-24.04