rename binary to tailcall & fix libc detection #634
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -46,7 +46,7 @@ async function genPlatformPackage() { | |||
| const binPath = `${packagePath}/bin` | |||
|
|
|||
| const targetPath = ext ? `../target/${target}/release/tailcall${ext}` : `../target/${target}/release/tailcall` | |||
| const tcPath = ext ? `${binPath}/tc${ext}` : `${binPath}/tc` | |||
| const tcPath = ext ? `${binPath}/tailcall${ext}` : `${binPath}/tailcall` | |||
There was a problem hiding this comment.
Suggested change
| const tcPath = ext ? `${binPath}/tailcall${ext}` : `${binPath}/tailcall` | |
| const tcPath = `${binPath}/tailcall${ext || ''}` |
the same applies to line 48.
If you want, feel free to create this variable with a default value instead
| libcFamily = fam | ||
| }) | ||
|
|
||
| const libcFamily = familySync() |
There was a problem hiding this comment.
we can't use top-level await?
amitksingh1490
added a commit
to ologbonowiwi/tailcall
that referenced
this pull request
Nov 17, 2023
amitksingh1490
added a commit
to ologbonowiwi/tailcall
that referenced
this pull request
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libcdetection to use synchronous call instead of asynctailcallfromtcas it clashes with built in utility with the same name on linux https://man7.org/linux/man-pages/man8/tc.8.html/closes #628