From bf2379193e305fd3674bf601a672ab24ea674698 Mon Sep 17 00:00:00 2001 From: Korbinian Kasberger Date: Thu, 7 Sep 2023 14:27:14 +0200 Subject: [PATCH 1/8] disabled buttons now have a border --- packages/bridge-ui-v2/src/components/Button/Button.svelte | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/packages/bridge-ui-v2/src/components/Button/Button.svelte b/packages/bridge-ui-v2/src/components/Button/Button.svelte index b93c011bb4..ff10e9bfff 100644 --- a/packages/bridge-ui-v2/src/components/Button/Button.svelte +++ b/packages/bridge-ui-v2/src/components/Button/Button.svelte @@ -21,6 +21,7 @@ export let outline = false; export let block = false; export let wide = false; + export let disabled = false; // Remember, with Tailwind's classes you cannot use string interpolation: `btn-${type}`. // The whole class name must appear in the code in order for Tailwind compiler to know @@ -45,7 +46,7 @@ }; $: classes = classNames( - 'btn h-auto min-h-fit border-0', + 'btn h-auto min-h-fit ', type === 'primary' ? 'body-bold' : 'body-regular', @@ -60,6 +61,8 @@ // since we're showing some important information. loading ? 'btn-disabled !text-primary-content' : null, + disabled ? 'border-1 border-primary-border' : 'border-0', + $$props.class, ); @@ -69,7 +72,7 @@ } - -

{$t('token_dropdown.label')}

+
+

{$t('token_dropdown.label')}

- + {$t('token_dropdown.add_custom')} + + + + +
From a0667f5bd1d7e5bc7582bc9d6bcd2835a1dfa0a5 Mon Sep 17 00:00:00 2001 From: Korbinian Kasberger Date: Thu, 7 Sep 2023 14:42:22 +0200 Subject: [PATCH 5/8] recipient and processing fee dialogs --- .../Bridge/ProcessingFee/ProcessingFee.svelte | 176 +++++++++--------- .../src/components/Bridge/Recipient.svelte | 52 +++--- 2 files changed, 116 insertions(+), 112 deletions(-) diff --git a/packages/bridge-ui-v2/src/components/Bridge/ProcessingFee/ProcessingFee.svelte b/packages/bridge-ui-v2/src/components/Bridge/ProcessingFee/ProcessingFee.svelte index 5b5295cbf6..920b6777cd 100644 --- a/packages/bridge-ui-v2/src/components/Bridge/ProcessingFee/ProcessingFee.svelte +++ b/packages/bridge-ui-v2/src/components/Bridge/ProcessingFee/ProcessingFee.svelte @@ -142,105 +142,107 @@ -

{$t('processing_fee.title')}

- -

{$t('processing_fee.description')}

- -
    - -
  • -
    - - - - {#if calculatingRecommendedAmount} - ETH - {:else if errorCalculatingRecommendedAmount} - {$t('processing_fee.recommended.error')} - {:else} - {formatEther(recommendedAmount)} ETH - {/if} - -
    - -
  • - - -
  • -
    +
    +

    {$t('processing_fee.title')}

    + +

    {$t('processing_fee.description')}

    + +
      + +
    • -
      -
    +
  • + + +
  • +
    +
    + + + {$t('processing_fee.none.text')} + +
    + +
    + + {#if !hasEnoughEth} + + {/if} +
  • - {#if !hasEnoughEth} - + +
  • +
    + + + {$t('processing_fee.custom.text')} + +
    + +
  • +
+
+ {#if selectedFeeMethod === ProcessingFeeMethod.CUSTOM} + + ETH {/if} - - - -
  • -
    - - - {$t('processing_fee.custom.text')} - -
    - -
  • - -
    - {#if selectedFeeMethod === ProcessingFeeMethod.CUSTOM} - - ETH - {/if} -
    -
    - - +
    +
    + + +
    diff --git a/packages/bridge-ui-v2/src/components/Bridge/Recipient.svelte b/packages/bridge-ui-v2/src/components/Bridge/Recipient.svelte index 028ab7f895..a8228fc309 100644 --- a/packages/bridge-ui-v2/src/components/Bridge/Recipient.svelte +++ b/packages/bridge-ui-v2/src/components/Bridge/Recipient.svelte @@ -92,31 +92,33 @@ -

    {$t('recipient.title')}

    - -

    {$t('recipient.description')}

    - -
    - -
    - -
    - - +
    +

    {$t('recipient.title')}

    + +

    {$t('recipient.description')}

    + +
    + +
    + +
    + + +
    From c420bfeb34274a4c8bdb9d95bccdd7b265fb8a35 Mon Sep 17 00:00:00 2001 From: Korbinian Kasberger Date: Thu, 7 Sep 2023 15:54:16 +0200 Subject: [PATCH 6/8] override functionality for border buttons --- .../Bridge/ProcessingFee/ProcessingFee.svelte | 6 +++++- .../src/components/Bridge/Recipient.svelte | 3 ++- .../bridge-ui-v2/src/components/Button/Button.svelte | 12 +++++++++++- .../components/TokenDropdown/AddCustomERC20.svelte | 1 + 4 files changed, 19 insertions(+), 3 deletions(-) diff --git a/packages/bridge-ui-v2/src/components/Bridge/ProcessingFee/ProcessingFee.svelte b/packages/bridge-ui-v2/src/components/Bridge/ProcessingFee/ProcessingFee.svelte index 920b6777cd..60cd5c8844 100644 --- a/packages/bridge-ui-v2/src/components/Bridge/ProcessingFee/ProcessingFee.svelte +++ b/packages/bridge-ui-v2/src/components/Bridge/ProcessingFee/ProcessingFee.svelte @@ -239,7 +239,11 @@ class="px-[28px] py-[10px] rounded-full w-auto bg-transparent !border border-primary-brand hover:border-primary-interactive-hover"> {$t('common.cancel')} - diff --git a/packages/bridge-ui-v2/src/components/Bridge/Recipient.svelte b/packages/bridge-ui-v2/src/components/Bridge/Recipient.svelte index a8228fc309..84560c72b4 100644 --- a/packages/bridge-ui-v2/src/components/Bridge/Recipient.svelte +++ b/packages/bridge-ui-v2/src/components/Bridge/Recipient.svelte @@ -115,7 +115,8 @@ type="primary" disabled={invalidAddress || !ethereumAddressBinding} class="px-[28px] py-[10px] rounded-full w-auto" - on:click={closeModal}> + on:click={closeModal} + hasBorder={true}> {$t('common.confirm')} diff --git a/packages/bridge-ui-v2/src/components/Button/Button.svelte b/packages/bridge-ui-v2/src/components/Button/Button.svelte index ff10e9bfff..5034bcc50b 100644 --- a/packages/bridge-ui-v2/src/components/Button/Button.svelte +++ b/packages/bridge-ui-v2/src/components/Button/Button.svelte @@ -23,6 +23,16 @@ export let wide = false; export let disabled = false; + export let hasBorder = false; + + let borderClasses: string = ''; + + if (hasBorder) { + borderClasses = 'border-1 border-primary-border'; + } else { + borderClasses = 'border-0'; + } + // Remember, with Tailwind's classes you cannot use string interpolation: `btn-${type}`. // The whole class name must appear in the code in order for Tailwind compiler to know // it must be included during build-time. @@ -61,7 +71,7 @@ // since we're showing some important information. loading ? 'btn-disabled !text-primary-content' : null, - disabled ? 'border-1 border-primary-border' : 'border-0', + disabled ? borderClasses : '', $$props.class, ); diff --git a/packages/bridge-ui-v2/src/components/TokenDropdown/AddCustomERC20.svelte b/packages/bridge-ui-v2/src/components/TokenDropdown/AddCustomERC20.svelte index 63c948e569..d6d9b7eca5 100644 --- a/packages/bridge-ui-v2/src/components/TokenDropdown/AddCustomERC20.svelte +++ b/packages/bridge-ui-v2/src/components/TokenDropdown/AddCustomERC20.svelte @@ -192,6 +192,7 @@ {:else}