Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol): allow whitelisting proposers #375

Merged
merged 4 commits into from
Dec 5, 2022
Merged

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Dec 2, 2022

Besides the whitelisting support for proposers, this PR also includes the following changes:

  • Move whitelisting to separate struct for easier cleanup
  • Rename constants so their names starts with "K_" for readability
  • Specify function/event parameter names explicitly if there are more than 2 parameters.
  • "Finalize" => "Verify"

Another purpose of this PR is to enable a cleaner tokenomics PR.

* Copy impl tokenomics (#373)

* undo tokenomics
@dantaik dantaik marked this pull request as ready for review December 2, 2022 03:49
@codecov
Copy link

codecov bot commented Dec 2, 2022

Codecov Report

Merging #375 (53cc4b9) into main (0652595) will decrease coverage by 1.11%.
The diff coverage is 12.19%.

❗ Current head 53cc4b9 differs from pull request most recent head b45ca43. Consider uploading reports for the commit b45ca43 to get more accurate results

@@            Coverage Diff             @@
##             main     #375      +/-   ##
==========================================
- Coverage   65.49%   64.38%   -1.12%     
==========================================
  Files          90       90              
  Lines        2484     2524      +40     
  Branches      286      292       +6     
==========================================
- Hits         1627     1625       -2     
- Misses        784      827      +43     
+ Partials       73       72       -1     
Flag Coverage Δ *Carryforward flag
bridge-ui 100.00% <ø> (ø) Carriedforward from 76c095d
protocol 59.00% <12.19%> (-1.90%) ⬇️
relayer 68.92% <ø> (ø) Carriedforward from 76c095d
ui 100.00% <ø> (ø) Carriedforward from 76c095d

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
packages/protocol/contracts/L1/v1/V1Proposing.sol 0.00% <0.00%> (ø)
packages/protocol/contracts/L1/v1/V1Proving.sol 0.00% <0.00%> (ø)
packages/protocol/contracts/L1/v1/V1Utils.sol 0.00% <0.00%> (ø)
packages/protocol/contracts/bridge/EtherVault.sol 100.00% <ø> (ø)
...rotocol/contracts/bridge/libs/LibBridgeProcess.sol 23.52% <0.00%> (ø)
.../protocol/contracts/bridge/libs/LibBridgeRetry.sol 88.88% <ø> (ø)
...protocol/contracts/bridge/libs/LibBridgeSignal.sol 86.95% <0.00%> (ø)
...ages/protocol/contracts/common/AddressResolver.sol 68.42% <ø> (ø)
...es/protocol/contracts/common/EssentialContract.sol 100.00% <ø> (ø)
...ges/protocol/contracts/libs/LibAnchorSignature.sol 100.00% <ø> (ø)
... and 14 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dantaik dantaik changed the title refactor(protocol): various refactor feat(protocol): allow whitelisting proposers Dec 2, 2022
@dantaik dantaik enabled auto-merge (squash) December 2, 2022 04:00
@dantaik dantaik merged commit 80b99a4 into main Dec 5, 2022
@dantaik dantaik deleted the various_refactor branch December 5, 2022 16:20
@github-actions github-actions bot mentioned this pull request Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants