chore(protocol): give more slots for verified blocks in ring buffer #17762
+65
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore(protocol): give more slots for verified blocks in ring buffer
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
This reverts commit 05615ca.
Brechtpd
approved these changes
Jul 8, 2024
adaki2004
approved these changes
Jul 8, 2024
davidtaikocha
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous, we only keep the last 512 verified block's data in the ring buffer. This may be problematic if a third party app, such as a prover pool, tries to settle prover-proposer payments based on who actually proved the blocks.
This PR allows up to 7200 * 5 = 36000 recently verified blocks to have data in the ring buffer.