Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol): use gasleft() in Bridge's retryMessage function #17708

Merged
merged 1 commit into from
Jun 30, 2024

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Jun 30, 2024

No description provided.

@dantaik dantaik marked this pull request as ready for review June 30, 2024 05:14
@dantaik dantaik enabled auto-merge June 30, 2024 05:15
@dantaik dantaik changed the title feat(protocol): use gasleft() in retryMessage fix(protocol): use gasleft() in Bridge's retryMessage function Jun 30, 2024
Copy link

feat(protocol): use gasleft() in retryMessage

Generated at commit: cf426f6cce4938715b83433993f1c3c33fe7ec24

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
2
2
0
8
42
54
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

Copy link
Contributor

@adaki2004 adaki2004 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, might be good to go out with the tomorrow update - so that the issue in subject (SC is the destOwner and cannot raise gas limit) can be resolved.

@dantaik dantaik added this pull request to the merge queue Jun 30, 2024
Merged via the queue into main with commit d86893c Jun 30, 2024
5 checks passed
@dantaik dantaik deleted the retry_message_gas_limit branch June 30, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants