Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(nfts): taikoons upgradeable v2 #17580

Merged
merged 11 commits into from
Jun 14, 2024
Merged

feat(nfts): taikoons upgradeable v2 #17580

merged 11 commits into from
Jun 14, 2024

Conversation

bearni95
Copy link
Contributor

@bearni95 bearni95 commented Jun 13, 2024 •
edited
Loading

In this PR:

  • Add upgrade deployment schema for Taikoons
  • Implement TaikoonTokenV2 with the following methods:
    • initializeV2, to call when upgrading
    • updateBaseURI (onlyOwner)
    • baseURI (public, view)
  • Upgrade forge script
  • Update token metadata
  • Deploy the upgrade on mainnet with the corrected IPFS hashes

@bearni95 bearni95 requested a review from dantaik June 13, 2024 11:18
@openzeppelin-code OpenZeppelin Code
Copy link

openzeppelin-code bot commented Jun 13, 2024 •
edited
Loading

feat(nfts): taikoons upgradeable v2

Generated at commit: 11c29fade7a70197a7b4b37d7b4d91efda912ef6

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 2
2
0
8
42
54
Dependencies Critical
High
Medium
Low
Note
Total		 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@bearni95 bearni95 requested a review from dantaik June 14, 2024 09:05
@bearni95 bearni95 requested a review from dantaik June 14, 2024 09:53
@bearni95 bearni95 added this pull request to the merge queue Jun 14, 2024
Merged via the queue into main with commit df855a5 Jun 14, 2024
5 checks passed
@bearni95 bearni95 deleted the taikoons-ipfs-hash-update branch June 14, 2024 12:13
@taiko-kitty taiko-kitty mentioned this pull request Jun 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bennettyong bennettyong bennettyong approved these changes

@dantaik dantaik dantaik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bearni95 @bennettyong @dantaik