Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bridge-ui): fix USDT approvals #17539

Merged
merged 5 commits into from
Jun 10, 2024
Merged

fix(bridge-ui): fix USDT approvals #17539

merged 5 commits into from
Jun 10, 2024

Conversation

KorbinianK
Copy link
Contributor

USDT behaves differently and was not supported correctly:

  • USDT does not work with the newer approve ABI of ERC20s
  • Approvals can't be adjusted, need to be reset to 0 first

@KorbinianK KorbinianK self-assigned this Jun 9, 2024
@davidtaikocha davidtaikocha added this pull request to the merge queue Jun 10, 2024
Merged via the queue into main with commit 37cb7af Jun 10, 2024
9 checks passed
@davidtaikocha davidtaikocha deleted the feat/bridge-ui--usdt-approval branch June 10, 2024 04:22
@taiko-kitty taiko-kitty mentioned this pull request Jun 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtaikocha davidtaikocha davidtaikocha approved these changes

@xiaodino xiaodino xiaodino approved these changes

@bearni95 bearni95 Awaiting requested review from bearni95

@cyberhorsey cyberhorsey Awaiting requested review from cyberhorsey

@dantaik dantaik Awaiting requested review from dantaik

Assignees

@KorbinianK KorbinianK

Labels
area.bridge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KorbinianK @davidtaikocha @xiaodino