fix(eventindexer): remove redundant opts.CorsOrigins check #17306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddl-hust
changed the title
cyberhorsey
approved these changes
Aug 19, 2024
|
LGTM! |
dantaik
approved these changes
Aug 30, 2024
davidtaikocha
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there's a logical issue in the handling of corsOrigins: the
Validatemethod checks ifopts.CorsOriginsis nil, and if so, returns an erroreventindexer.ErrNoCORSOrigins. However, in theNewServermethod, even ifopts.CorsOriginsis nil, it's set to a default value of []string{"*"}.cause the check in the Validate method is redundant, as the nil case is already handled in the NewServer method.