fix(eventindexer): nft balance changes should be wrapped in db transaction

[the-laziest]

Increase and subtract of nft balance in db should be done in transaction to prevent corrupted data in case of error in second query

[xiaodino]

@the-laziest Could you explain more what the PR is for and a way to reproduce the issue?

[the-laziest]

@the-laziest Could you explain more what the PR is for and a way to reproduce the issue?

Sure, @xiaodino, if there will be an error for some reason here (related to db connection or smth like that), then in database NFT balance will be increased for To address, but not decreased for From address

[cyberhorsey]

Three notes:

1. I'm happy to merge this PR, however, we will not use any of this code, and it will be deleted for mainnet (since we will use professional NFT indexing APIs that already exist), so it is not robust on purpose.

2. We can delete the existing IncreaseBalance and SubtractBalance methods now, since they are unused, so if this PR is to be merged, we should do that.

3. gofmt has not been run on this code, and thus, it is failing basic formatting, as well as it is not passing our general linter warnings for golangcilint.

[the-laziest]

@cyberhorsey, updated all mentioned things

[cyberhorsey]

Left two comments.

[codecov]

Codecov Report

Attention: Patch coverage is 32.14286% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 17.87%. Comparing base (f53766b) to head (ef07bba).
Report is 417 commits behind head on main.

Files	Patch %	Lines
...ckages/eventindexer/indexer/index_nft_transfers.go	0.00%	12 Missing ⚠️
packages/eventindexer/pkg/repo/nft_balance.go	56.25%	2 Missing and 5 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #16943      +/-   ##
==========================================
- Coverage   26.82%   17.87%   -8.96%     
==========================================
  Files         105       45      -60     
  Lines        6188     1992    -4196     
==========================================
- Hits         1660      356    -1304     
+ Misses       4348     1593    -2755     
+ Partials      180       43     -137     

Flag	Coverage Δ
eventindexer	17.87% <32.14%> (+0.64%)	⬆️
guardian-prover-health-check	?
relayer	?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[the-laziest]

@cyberhorsey , could you please take a look at it?

[cyberhorsey]

LGTM. Thanks for doing the requested changes.

has been answered

[the-laziest]

@cyberhorsey , can I please ask for contributor poap, if it's applicable to this pr

[RogerLamTd]

@gitpoap-bot please give @the-laziest a poap

[gitpoap-bot]

Congrats, @the-laziest ! You've earned a GitPOAP for your contribution!

GitPOAP: 2024 Taiko Contributor:

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.