Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bridge-ui): issue with decimals #13892

Merged
merged 2 commits into from
Jun 6, 2023
Merged

fix(bridge-ui): issue with decimals #13892

merged 2 commits into from
Jun 6, 2023

Conversation

jscriptcoder
Copy link
Contributor

@jscriptcoder jscriptcoder commented Jun 6, 2023

We're not making good use of decimals, assuming 18 decimals for all ERC20 tokens also

@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Merging #13892 (e32b8e8) into main (23fb29d) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main   #13892      +/-   ##
==========================================
+ Coverage   51.47%   51.55%   +0.07%     
==========================================
  Files         143      144       +1     
  Lines        3792     3798       +6     
  Branches      332      333       +1     
==========================================
+ Hits         1952     1958       +6     
  Misses       1726     1726              
  Partials      114      114              
Flag Coverage Δ *Carryforward flag
bridge-ui 94.31% <100.00%> (+0.04%) ⬆️
eventindexer 77.28% <ø> (ø) Carriedforward from 9fad628
protocol 0.00% <ø> (ø) Carriedforward from 9fad628
relayer 59.57% <ø> (ø) Carriedforward from 9fad628
ui 100.00% <ø> (ø) Carriedforward from 9fad628

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
packages/bridge-ui/src/domain/bridge.ts 100.00% <ø> (ø)
packages/bridge-ui/src/bridge/ERC20Bridge.ts 80.64% <100.00%> (ø)
packages/bridge-ui/src/bridge/ETHBridge.ts 77.35% <100.00%> (ø)
...ges/bridge-ui/src/relayer-api/RelayerAPIService.ts 100.00% <100.00%> (ø)
packages/bridge-ui/src/storage/StorageService.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jscriptcoder jscriptcoder marked this pull request as ready for review June 6, 2023 11:49
@jscriptcoder jscriptcoder added this pull request to the merge queue Jun 6, 2023
Merged via the queue into main with commit fbed474 Jun 6, 2023
@jscriptcoder jscriptcoder deleted the fix_decimals branch June 6, 2023 12:01
@github-actions github-actions bot mentioned this pull request Jun 6, 2023
dantaik pushed a commit that referenced this pull request Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants