Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(relayer): hardcode gas limit to determine if a message needs extra gas to deploy a contract #13764

Merged
merged 4 commits into from
May 16, 2023

Conversation

cyberhorsey
Copy link
Contributor

@cyberhorsey cyberhorsey commented May 15, 2023

nodes seem unable to estimate gas correctly for contract deployments, this should fix that.

@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Merging #13764 (55a9eaf) into main (59ed335) will decrease coverage by 0.67%.
The diff coverage is 12.50%.

@@            Coverage Diff             @@
##             main   #13764      +/-   ##
==========================================
- Coverage   47.97%   47.30%   -0.67%     
==========================================
  Files         131      131              
  Lines        3339     3327      -12     
  Branches      310      310              
==========================================
- Hits         1602     1574      -28     
- Misses       1636     1654      +18     
+ Partials      101       99       -2     
Flag Coverage Δ *Carryforward flag
bridge-ui 96.16% <ø> (ø) Carriedforward from 1c76768
eventindexer 82.08% <ø> (ø) Carriedforward from 1c76768
protocol 0.00% <ø> (ø) Carriedforward from 1c76768
relayer 61.17% <12.50%> (-1.37%) ⬇️
ui 100.00% <ø> (ø) Carriedforward from 1c76768

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
packages/relayer/indexer/handle_event.go 43.03% <0.00%> (-12.70%) ⬇️
packages/relayer/message/process_message.go 40.98% <0.00%> (-5.61%) ⬇️
packages/relayer/indexer/service.go 74.25% <22.22%> (-1.79%) ⬇️
packages/relayer/cli/cli.go 59.32% <100.00%> (+0.30%) ⬆️
packages/relayer/message/processor.go 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cyberhorsey cyberhorsey added this pull request to the merge queue May 16, 2023
Merged via the queue into main with commit 0615bf6 May 16, 2023
@cyberhorsey cyberhorsey deleted the relayer_gas_if_contract_not_deployed branch May 16, 2023 07:32
@github-actions github-actions bot mentioned this pull request May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants