Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add theme switch on website home page #13084

Merged
merged 2 commits into from
Feb 2, 2023

Conversation

shadab-taiko
Copy link
Contributor

@shadab-taiko shadab-taiko commented Feb 2, 2023

Fixes #13028

@RogerLamTd
Copy link
Contributor

Looks good! Might want to make it a toggle button like the one on the bridge at the top of the page? Could make it easier to find and access.

@shadab-taiko shadab-taiko merged commit 34c5501 into main Feb 2, 2023
@shadab-taiko shadab-taiko deleted the website-home-theme-switch branch February 2, 2023 14:06
@github-actions github-actions bot mentioned this pull request Feb 2, 2023
@wolfderechter
Copy link
Contributor

Looks good! Might want to make it a toggle button like the one on the bridge at the top of the page? Could make it easier to find and access.

I agree, it should be on top of the page, it's way too hard to find right now

@shadab-taiko
Copy link
Contributor Author

Looks good! Might want to make it a toggle button like the one on the bridge at the top of the page? Could make it easier to find and access.

I agree, it should be on top of the page, it's way too hard to find right now
@RogerLamTd @wolfderechter
The Nextra theme that we are using places it like so and thus I have replicated it.

@Eleleth77
Copy link

agreed. Main page top right

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(website): toggle theme button only appears on mobile screens
6 participants