Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bridge): bridge Ui should estimate gas not used hardcoded gas limit #12962

Merged
merged 2 commits into from
Jan 17, 2023

Conversation

cyberhorsey
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jan 17, 2023

Codecov Report

Merging #12962 (d8ec071) into main (7692ac8) will increase coverage by 0.03%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##             main   #12962      +/-   ##
==========================================
+ Coverage   66.36%   66.39%   +0.03%     
==========================================
  Files         113      113              
  Lines        3047     3050       +3     
  Branches      357      357              
==========================================
+ Hits         2022     2025       +3     
  Misses        949      949              
  Partials       76       76              
Flag Coverage Δ *Carryforward flag
bridge-ui 92.61% <80.00%> (+0.02%) ⬆️
protocol 59.23% <ø> (ø) Carriedforward from 7692ac8
relayer 69.10% <ø> (ø) Carriedforward from 7692ac8
ui 100.00% <ø> (ø) Carriedforward from 7692ac8

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
packages/bridge-ui/src/erc20/bridge.ts 93.10% <75.00%> (ø)
packages/bridge-ui/src/eth/bridge.ts 92.59% <83.33%> (+0.43%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cyberhorsey cyberhorsey merged commit 1eb3c6f into main Jan 17, 2023
@cyberhorsey cyberhorsey deleted the estimate_gas branch January 17, 2023 14:46
@github-actions github-actions bot mentioned this pull request Jan 18, 2023
davidtaikocha pushed a commit that referenced this pull request Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants