You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When I reviewed #41, I thought the differences in its implementation were fine, but in reality, we have missed several problems that would not have occurred if the implementation had been based on std::sync::Arc (#137, #139, 1).
This will not necessarily be easy, since the standard library uses many unstable features.
When I was originally writing the Arc code, I tried to follow along with the standard library's version, but polyfilling bits and pieces in when unstable features were used.
It might be nice to bump the MSRV of portable-atomic-util higher than 1.34 so we gain access to some of these features, such as addr_of.
The implementation is in #142. addr_of_mut in as_ptr is not really important; the layout calculation is needed anyway to implement from_raw, and it can be used in as_ptr, so making the layout calculation work in the older version is the important point.
When I reviewed #41, I thought the differences in its implementation were fine, but in reality, we have missed several problems that would not have occurred if the implementation had been based on std::sync::Arc (#137, #139, 1).
This will not necessarily be easy, since the standard library uses many unstable features.
Footnotes
UPDATE: There are also cases where there are implementations that do not exist in the std::sync::Arc... ↩
The text was updated successfully, but these errors were encountered: