Improve tests for --no-private

Author: taiki-e

tests/fixtures/real_root_public/Cargo.toml

@@ -0,0 +1,22 @@
+[package]
+name = "real"
+version = "0.0.0"
+
+[workspace]
+members = [
+    "member1",
+    "member2",
+    "member3",
+    ".",
+]
+
+[features]
+default = []
+a = []
+b = []
+c = []
+
+[dependencies]
+member1 = { path = "member1", optional = true }
+
+[dev-dependencies]

tests/fixtures/real_root_public/member1/Cargo.toml

@@ -0,0 +1,13 @@
+[package]
+name = "member1"
+version = "0.0.0"
+
+[features]
+default = []
+a = []
+b = []
+c = []
+
+[dependencies]
+
+[dev-dependencies]

tests/fixtures/real_root_public/member1/src/lib.rs

@@ -0,0 +1 @@
+

tests/fixtures/real_root_public/member1/src/main.rs

@@ -0,0 +1,11 @@
+fn main() {
+    println!("hello!");
+    #[cfg(feature = "default")]
+    println!("default");
+    #[cfg(feature = "a")]
+    println!("a");
+    #[cfg(feature = "b")]
+    println!("b");
+    #[cfg(feature = "c")]
+    println!("c");
+}

tests/fixtures/real_root_public/member2/Cargo.toml

@@ -0,0 +1,14 @@
+[package]
+name = "member2"
+version = "0.0.0"
+publish = false
+
+[features]
+default = []
+a = []
+b = []
+c = []
+
+[dependencies]
+
+[dev-dependencies]

tests/fixtures/real_root_public/member2/src/lib.rs

@@ -0,0 +1 @@
+

tests/fixtures/real_root_public/member2/src/main.rs

@@ -0,0 +1,11 @@
+fn main() {
+    println!("hello!");
+    #[cfg(feature = "default")]
+    println!("default");
+    #[cfg(feature = "a")]
+    println!("a");
+    #[cfg(feature = "b")]
+    println!("b");
+    #[cfg(feature = "c")]
+    println!("c");
+}

tests/fixtures/real_root_public/member3/Cargo.toml

@@ -0,0 +1,15 @@
+[package]
+name = "member3"
+version = "0.0.0"
+publish = true
+
+[features]
+default = ["a"]
+a = []
+b = []
+c = []
+
+[dependencies]
+member2 = { path = "../member2" }
+
+[dev-dependencies]

tests/fixtures/real_root_public/member3/src/lib.rs

@@ -0,0 +1 @@
+

tests/fixtures/real_root_public/member3/src/main.rs

@@ -0,0 +1,11 @@
+fn main() {
+    println!("hello!");
+    #[cfg(feature = "default")]
+    println!("default");
+    #[cfg(feature = "a")]
+    println!("a");
+    #[cfg(feature = "b")]
+    println!("b");
+    #[cfg(feature = "c")]
+    println!("c");
+}

tests/fixtures/real_root_public/src/lib.rs

@@ -0,0 +1 @@
+

tests/fixtures/real_root_public/src/main.rs

@@ -0,0 +1,21 @@
+fn main() {
+    println!("hello!");
+    #[cfg(feature = "default")]
+    println!("default");
+    #[cfg(feature = "a")]
+    println!("a");
+    #[cfg(feature = "b")]
+    println!("b");
+    #[cfg(feature = "c")]
+    println!("c");
+}
+
+#[cfg(test)]
+mod tests {
+    #[test]
+    fn test() {}
+
+    #[ignore]
+    #[test]
+    fn test_ignored() {}
+}

tests/test.rs

@@ -147,39 +147,81 @@ fn virtual_all_in_subcrate() {
 
 #[test]
 fn real_ignore_private() {
-    // --no-private is not supported yet with workspace with private root crate
-    let flag = "--ignore-private";
-    cargo_hack(["check", flag])
-        .assert_success("real")
-        .stderr_not_contains(
-            "
-            running `cargo check` on member1
-            skipped running on private package `member1`
-            running `cargo check` on member2
-            skipped running on private package `member2`
-            running `cargo check` on real
-            ",
-        )
-        .stderr_contains("skipped running on private package `real`");
+    for flag in ["--ignore-private", "--no-private"] {
+        if flag == "--no-private" {
+            // --no-private is not supported yet with workspace with private root crate
+            cargo_hack(["check", flag]).assert_failure("real").stderr_contains(
+                "--no-private is not supported yet with workspace with private root crate",
+            );
+            cargo_hack(["check", "--all", flag]).assert_failure("real").stderr_contains(
+                "--no-private is not supported yet with workspace with private root crate",
+            );
+        } else {
+            cargo_hack(["check", flag])
+                .assert_success("real")
+                .stderr_contains("skipped running on private package `real`")
+                .stderr_not_contains(
+                    "
+                    running `cargo check` on member1
+                    skipped running on private package `member1`
+                    running `cargo check` on member2
+                    skipped running on private package `member2`
+                    running `cargo check` on real
+                    ",
+                );
+
+            cargo_hack(["check", "--all", flag])
+                .assert_success("real")
+                .stderr_contains(
+                    "
+                    running `cargo check` on member1
+                    skipped running on private package `member2`
+                    running `cargo check` on member3
+                    skipped running on private package `real`
+                    ",
+                )
+                .stderr_not_contains(
+                    "
+                    skipped running on private package `member1`
+                    running `cargo check` on member2
+                    skipped running on private package `member3`
+                    running `cargo check` on real
+                    ",
+                );
+        }
 
-    cargo_hack(["check", "--all", flag])
-        .assert_success("real")
-        .stderr_contains(
-            "
-            running `cargo check` on member1
-            skipped running on private package `member2`
-            running `cargo check` on member3
-            skipped running on private package `real`
-            ",
-        )
-        .stderr_not_contains(
-            "
-            skipped running on private package `member1`
-            running `cargo check` on member2
-            skipped running on private package `member3`
-            running `cargo check` on real
-            ",
-        );
+        cargo_hack(["check", flag])
+            .assert_success("real_root_public")
+            .stderr_contains("running `cargo check` on real")
+            .stderr_not_contains(
+                "
+                running `cargo check` on member1
+                skipped running on private package `member1`
+                running `cargo check` on member2
+                skipped running on private package `member2`
+                skipped running on private package `real`
+                ",
+            );
+
+        cargo_hack(["check", "--all", flag])
+            .assert_success("real_root_public")
+            .stderr_contains(
+                "
+                running `cargo check` on member1
+                skipped running on private package `member2`
+                running `cargo check` on member3
+                running `cargo check` on real
+                ",
+            )
+            .stderr_not_contains(
+                "
+                skipped running on private package `member1`
+                running `cargo check` on member2
+                skipped running on private package `member3`
+                skipped running on private package `real`
+                ",
+            );
+    }
 }
 
 #[test]