Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pb-rs fails when processing a oneof with a semicolon #261

Open
kckeiks opened this issue Jun 20, 2024 · 1 comment · May be fixed by #264
Open

pb-rs fails when processing a oneof with a semicolon #261

kckeiks opened this issue Jun 20, 2024 · 1 comment · May be fixed by #264

Comments

@kckeiks
Copy link

kckeiks commented Jun 20, 2024

pb-rs (version 0.10.0) fails when converting this file https://github.com/onnx/onnx/blob/main/onnx/onnx.proto#L692 and it succeeds when I remove that semicolon. Is this expected?
@kckeiks
Copy link
Author

kckeiks commented Jun 20, 2024

In addition, converting with --dont_use_cow was adding lifetimes where they were not expected causing struct takes 0 lifetime arguments but 1 lifetime argument was supplied. Should I open a different issue for this?

@HiceS HiceS mentioned this issue Sep 3, 2024
Open
@qazxcdswe123 qazxcdswe123 linked a pull request Oct 16, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add oneof trailing semi support qazxcdswe123/quick-protobuf
1 participant
@kckeiks