[BUGFIX] change markup for news list #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hputzek
force-pushed
the
change_markup_for_news_list_items
branch
from
52d8fd4 to
4d3d722
Compare
|
@hputzek Thanks for your PR! But there is some linting errors to take care of. |
|
Thanks, I'll fix them. (In a few days)👍On Dec 27, 2017 07:48, Mattias Nilsson <[email protected]> wrote:@hputzek Thanks for your PR! But there is some linting errors to take care of.
—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or mute the thread.
|
News list had a bug and therefore did not scale properly depending on screensize. Absolute positioning and fixed heigths are very hard to handle in responsive designs. Therefore the markup was changed: Bootstrap grid classes are used now, this saves code prevents positioning related bugs/problems. The grid items are positioned with display: 'flex', which allows sizing the rows without using explicit, fixed values.
hputzek
force-pushed
the
change_markup_for_news_list_items
branch
from
4d3d722 to
a5c3288
Compare
dmh
added a commit
that referenced
this pull request
Feb 16, 2018
dmh
pushed a commit
that referenced
this pull request
Jun 7, 2018
…mages. Accessibility * [FEATURE] revert "[BUGFIX] partly revert - improve news list accessibility (#343)" This reverts commit ed1b624. * [FEATURE] revert "[BUGFIX] revert - change markup for news list (#373)" This reverts commit a4286d0. * [FEATURE] revert "[BUGFIX] revert PR adjust image height settings for news cards template (#382)" This reverts commit b305f6a. * [FEATURE] revert "[BUGFIX] revert PR Improve news cards accessibility (#351)" This reverts commit 2d33074. * [FEATURE] revert "[BUGFIX] revert news-carousel accessibility improvements (#352)" This reverts commit f1b155e. * Issue #83227: Add object-fit polyfill and remove background images * update css/less * remove unnecessary tag to fix error * adjust less formatting for stylelint * update css/less * remove wrong indentation * update css/less
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
News list had a bug and therefore did not scale properly depending on screensize.
(There are somtimes big gaps between elements etc...)
Absolute positioning and fixed heigths are very hard to handle in responsive designs.
Therefore the markup was changed:
Bootstrap grid classes are used now, this saves code & prevents positioning related bugs/problems.
The grid items are positioned with display: 'flex', which allows sizing the rows without using explicit, fixed values.
If no height is given to the
- Tag it looks like this:Because I wanted to keep the design nearly the same as before, I decided to set a fixed height to the article element, so this is what this PR contains:
If you have any requests before merging, keep me informed.