[FEATURE] more accessible news-carousel #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* use article tag for each news section * use buttons for prev/next navigation * Hide previous/next navigation and pagination for screenreaders: the see the whole list of news anyway and therefore have no additional from those elements * use image tags instead of background images * make focus visible on a-tags of focused images
|
There are some linting issues. dev/styles/main/plugins/news/newsCarousel.less |
resolve linting error (missing empty line between statements in less file)
|
Thanks for your your hint, I'll run the linter next time before committing ;-) |
|
This PR causing bugs in FE part. It should be reviewed again. |
dmh
added a commit
that referenced
this pull request
Feb 15, 2018
dmh
pushed a commit
that referenced
this pull request
Jun 7, 2018
…mages. Accessibility * [FEATURE] revert "[BUGFIX] partly revert - improve news list accessibility (#343)" This reverts commit ed1b624. * [FEATURE] revert "[BUGFIX] revert - change markup for news list (#373)" This reverts commit a4286d0. * [FEATURE] revert "[BUGFIX] revert PR adjust image height settings for news cards template (#382)" This reverts commit b305f6a. * [FEATURE] revert "[BUGFIX] revert PR Improve news cards accessibility (#351)" This reverts commit 2d33074. * [FEATURE] revert "[BUGFIX] revert news-carousel accessibility improvements (#352)" This reverts commit f1b155e. * Issue #83227: Add object-fit polyfill and remove background images * update css/less * remove unnecessary tag to fix error * adjust less formatting for stylelint * update css/less * remove wrong indentation * update css/less
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use article tag for each news section
use buttons for prev/next navigation
Hide previous/next navigation and pagination for screenreaders: the see the whole list of news anyway and therefore have no additional from those elements
use image tags instead of background images
make focus visible on a-tags of focused images