[FEATURE] Add aria-attributes to social icons #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hputzek
commented
Nov 3, 2017
hputzek
commented
- Add aria label to link
- hide icon from screenreaders
* Add aria label to link * hide icon from screenreaders
MattiasNilsson
requested changes
Nov 16, 2017
| </f:then> | ||
| <f:else> | ||
| <a class="social-icons__item" href="{theme:constant(constant:'themes.configuration.socialmedia.xingLink')}" | ||
| target="_blank" title="Xing"><span class="icons icon-t3-xing"></span></a> | ||
| target="_blank" title="Xing" aria-label="Xing"><span aria-hidden="true" class="icons icon-t3-xing"></span></a> |
There was a problem hiding this comment.
Change so that the indent is 1 space instead of 2.
| </f:else> | ||
| </f:if> | ||
| </f:if> | ||
| <f:if condition="{theme:constant(constant:'themes.configuration.socialmedia.useVimeo')}"> | ||
| <f:if condition="{settings.vimeoLink}"> | ||
| <f:then> | ||
| <a class="social-icons__item" href="{settings.vimeoLink}" | ||
| target="_blank" title="Vimeo"><span class="icons icon-t3-vimeo"></span></a> | ||
| target="_blank" title="Vimeo" aria-label="Vimeo"><span aria-hidden="true" class="icons icon-t3-vimeo"></span></a> |
There was a problem hiding this comment.
Change so that the indent is 1 space instead of 2.
| </f:then> | ||
| <f:else> | ||
| <a class="social-icons__item" href="{theme:constant(constant:'themes.configuration.socialmedia.vimeoLink')}" | ||
| target="_blank" title="Vimeo"><span class="icons icon-t3-vimeo"></span></a> | ||
| target="_blank" title="Vimeo" aria-label="Vimeo"><span aria-hidden="true" class="icons icon-t3-vimeo"></span></a> |
There was a problem hiding this comment.
Change so that the indent is 1 space instead of 2.
remove obsolete space between attributes in affected tags
|
I removed the obsolete spaces now, thanks for your hint. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.