[FEATURE]: add accessibility for logo carousel #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aennafae
commented
Nov 1, 2017
aennafae
commented
- add tabindex to access prev/next icon
- add aria-labels for prev/next icon
- control autoplay in element settings
|
This looks good! 👍 Just a merge conflict to resolve. |
websi
force-pushed
the
logocarousel-accessibility
branch
2 times, most recently
from
49c3064 to
7502047
Compare
* add tabindex to access prev/next icon * add aria-label for prev/next icon * control autoplay in element settings
websi
force-pushed
the
logocarousel-accessibility
branch
from
7502047 to
165fd6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.