Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[!!!][BUGFIX] use NoBgImage layout for content elements based on gridelements ext. except grids, fix #255 #278

Merged
merged 1 commit into from
Sep 14, 2017

Conversation

dmh
Copy link
Member

@dmh dmh commented Sep 12, 2017

My suggestion to use NoBgImage for content elements based on Gridelements but not grids itself

NoBgImage layout doesn't have those options lib.responsiveBackgroundImage and data.flexform_container and we do not need it for this elements: SliderContainer, Collapsible, Parallax etc.

It also can cause bugs:
#255

@dmh dmh requested a review from pixelmatseriks September 12, 2017 15:35
@MattiasNilsson MattiasNilsson merged commit 8b950c6 into master Sep 14, 2017
@MattiasNilsson MattiasNilsson deleted the useNoBgImageLayout branch September 19, 2017 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants