Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Felayout bug fixes #232

Merged
merged 4 commits into from
Jun 1, 2017
Merged

Felayout bug fixes #232

merged 4 commits into from
Jun 1, 2017

Conversation

mesosa
Copy link
Contributor

@mesosa mesosa commented May 30, 2017

fixes bug #225
fixes bug #224

@mesosa mesosa requested a review from dmh May 30, 2017 09:31
@dmh
Copy link
Member

dmh commented Jun 1, 2017

@mesosa
Suggestion for the future pull requests:
We are using Squash type of merging, so in your case commit message will be: Felayout bug fixes - wich is not proper according to guidelines.
Also better to divide it into two pull requests if you have two different tasks/bugs to fix.
Everything else is great, I tested it on different types of menu and didn't find any bugs. Great work!

@dmh dmh merged commit b0bb730 into master Jun 1, 2017
@pixelmatseriks pixelmatseriks deleted the felayoutBugFixes branch June 8, 2017 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmh dmh Awaiting requested review from dmh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mesosa @dmh