parallax-video called by data-values instead of by javascript #423
Assignees
Labels
Comments
Merged
dmh
pushed a commit
that referenced
this issue
Jun 22, 2018
* [TASK] upgraded jarallax to 1.10.3. - Updated the javascript configuration for it. * [FIX] jarallax - better handling of http/https urls (https urls would break in Edge) * [TASK] jarallax - disable parallax-effect in Edge, since the effect generally lags and doesn't currently work in EdgeHTML17 (see issue #110 in github) * [FIX] Parallax grid-element: - changed attribute on parallax-video from data-jarallax-video to data-video-url. - changed javascript for parallax-video to use this field - removed css for parallax that overwrote the background-image (the js of jarallax takes cares of this) - we can't disable parallax for Edge on video-elements without also disabling the video, so enabled it again (compared to images it does seem to work in latest Edge) - compileLess, compiledCss * [TASK] removal of console.log * [TASK] removal of console.log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In /Resources/Private/Templates/GridElements/Parallax.html the parallax-video uses the data attribute data-jarallax-video for the video-url.
This is enough to trigger jarallax and thus the javascript that deals with the configuration of parallax-video-classes in /felayout_t3kit/dev/js/main/contentElements/parallax.js
is being ignored (from my testing).
I suggest that we either change it so (1) all jarallax "items" are triggered from javascript or (2) that we add the other data-parameters into the HTML-template. The first suggestion is probably the safer one.
The text was updated successfully, but these errors were encountered: