Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease "view (1700)" priority in ext:theme template selection #244

Closed
Sengchheang opened this issue Jun 20, 2017 · 0 comments
Closed

Decrease "view (1700)" priority in ext:theme template selection #244

Sengchheang opened this issue Jun 20, 2017 · 0 comments

Comments

@Sengchheang
Copy link

Sengchheang commented Jun 20, 2017

in web/typo3conf/ext/theme_t3kit/Configuration/TypoScript/Library/plugin.themes.setupts

plugin.tx_themes { view { templateRootPaths { 1700 = EXT:theme_t3kit/Resources/Private/Templates/ } partialRootPaths { 1700 = EXT:theme_t3kit/Resources/Private/Partials/ } layoutRootPaths { 1700 = EXT:theme_t3kit/Resources/Private/Layouts/ } } }

the above TS defines the priority of theme_t3kit in view selection of ext:theme.
However ext:theme seems to take this into account already even without above code when the template is activated in Theme module.

see in web/typo3conf/ext/themes/Configuration/TypoScript/setup.txt
view { templateRootPaths { 100 = EXT:themes/Resources/Private/Templates/ 500 = {$themes.resourcesPrivatePath}Templates/ } partialRootPaths { 100 = EXT:themes/Resources/Private/Partials/ 500 = {$themes.resourcesPrivatePath}Partials/ } layoutRootPaths { 100 = EXT:themes/Resources/Private/Layouts/ 500 = {$themes.resourcesPrivatePath}Layouts/ } }

In this case, the selected theme is 500 while 1700 brought by ext:theme_t3kit is too high for sub-theme to take place.

see https://github.com/t3kit/subtheme_t3kit_template/blob/master/Configuration/TypoScript/Library/plugin.themes.setupts

there is an example block (supposed to be always un-commented) to make the template overriding works. This block will be not necessary when 1700 in ext:theme_t3kit is decrease to less than 500.

If the above suggestion is not applied, the image below will demonstrate the particular case for sub-theme user having issue with view priority.
screen shot 2017-06-20 at 3 34 43 pm

(I am not t3kit Slack, please ping me if the above comment is not so clear.)

@dmh dmh closed this as completed in 701bbc8 Jul 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant