Skip to content

Commit

Permalink
[TASK]: add h2 heading to provide valid html structure (#342)
Browse files Browse the repository at this point in the history
Headlines in footer starts normally from h3 or h4, the page heading structure breaks without leading h2.
Add role for footer to mark area for all screen readers.
  • Loading branch information
Anna Färber authored and MattiasNilsson committed Nov 24, 2017
1 parent 4b36c9b commit 8dc7a67
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
4 changes: 3 additions & 1 deletion Resources/Private/Language/locallang.xlf
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,9 @@
<trans-unit id="skipLinks.mainContent" xml:space="preserve">
<source>Skip to main content</source>
</trans-unit>

<trans-unit id="footer.firstHeadline">
<source>Footer</source>
</trans-unit>

<!--Extensions-->
<!--News-->
Expand Down
6 changes: 4 additions & 2 deletions Resources/Private/Partials/Footer/Footer.html
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,10 @@
<!-- theme_t3kit: Partials/Footer/Footer.html [begin] -->


<footer class="footer">

<footer class="footer" role="contentinfo">

<f:comment>H2 is needed to provide valid HTML structure https://www.w3.org/WAI/tutorials/page-structure/headings/</f:comment>
<h2 class="hidden" aria-hidden="true"><f:translate key="footer.firstHeadline" extensionName="theme_t3kit"/></h2>
<f:cObject typoscriptObjectPath="lib.footer" />

</footer>
Expand Down

0 comments on commit 8dc7a67

Please sign in to comment.