Skip to content

Commit

Permalink
[BUGFIX] revert PR Improve news cards accessibility (#351)
Browse files Browse the repository at this point in the history
  • Loading branch information
dmh committed Feb 15, 2018
1 parent c96b75b commit 2d33074
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 34 deletions.
16 changes: 4 additions & 12 deletions Resources/Private/Extensions/News/Partials/List/Cards.html
Original file line number Diff line number Diff line change
Expand Up @@ -33,19 +33,13 @@
<div class="news-cards__img-wrap">
<f:alias map="{mediaElement: '{newsItem.mediaPreviews.0}'}">
<f:if condition="{mediaElement.originalResource.type} == 2">
<div class="news-cards__media-preview"
style="height:{f:if(condition:settings.media.maxHeight, then: settings.media.maxHeight, else: settings.list.media.image.maxHeight)}px">
<f:media file="{mediaElement}" width="768"/>
</div>
<div class="news-cards__media-preview" style="background-image:url('{f:uri.image(src: mediaElement.uid, treatIdAsReference: 1)}');"></div>
</f:if>
<f:if condition="{mediaElement.originalResource.type} == 4">
<f:media file="{mediaElement}" additionalConfig="{loop: '0', autoplay: '0'}"/>
</f:if>
<f:if condition="{mediaElement.originalResource.type} == 5">
<div class="news-cards__media-preview"
style="height:{f:if(condition: settings.detail.media.image.maxHeight, then: settings.list.media.image.maxHeight, else: settings.media.maxHeight)}px">
<f:media file="{mediaElement}" width="768"/>
</div>
<div class="news-cards__media-preview" style="background-image:url('{f:uri.image(src: mediaElement.uid, treatIdAsReference: 1)}');"></div>
</f:if>
</f:alias>
</div>
Expand All @@ -54,9 +48,7 @@
<f:if condition="{settings.displayDummyIfNoMedia}">
<div class="news-cards__img-wrap">
<div class="no-media-element">
<div class="news-cards__media-preview"
style="background-image:url('{f:uri.image(src: settings.list.media.dummyImage, treatIdAsReference: 1)}');
height:{f:if(condition:settings.media.maxHeight, then: settings.media.maxHeight, else: settings.list.media.image.maxHeight)}px"></div>
<div class="news-cards__media-preview" style="background-image:url('{f:uri.image(src: settings.list.media.dummyImage, treatIdAsReference: 1)}');"></div>
</div>
</div>
</f:if>
Expand Down Expand Up @@ -100,7 +92,7 @@ <h3>{newsItem.title}</h3>
</div>
</n:link>
<div class="news-cards__more-link">
<n:link newsItem="{newsItem}" settings="{settings}" class="more" additionalAttributes="{aria-label: '{f:translate(key:\'news.more-link.linktext\', extensionName:\'Theme_t3kit\')}{newsItem.title}'}" title="{f:translate(key:'news.more-link.linktext', extensionName:'Theme_t3kit')}{newsItem.title}">
<n:link newsItem="{newsItem}" settings="{settings}" class="more" title="{newsItem.title}">
<f:translate key="more-link"/>
</n:link>
</div>
Expand Down
12 changes: 0 additions & 12 deletions Resources/Private/Language/de.locallang.xlf
Original file line number Diff line number Diff line change
Expand Up @@ -44,18 +44,6 @@
<trans-unit id="breadcrumb_label" xml:space="preserve">
<target>Sie sind hier</target>
</trans-unit>
<!--News-->
<!-- news custom labels -->
<trans-unit id="news.more-link.linktext" xml:space="preserve">
<target>Öffne News - </target>
</trans-unit>
<!-- news pagination aria labels -->
<trans-unit id="paginate.list.ariaLabel" xml:space="preserve">
<target>Paginierung</target>
</trans-unit>
<trans-unit id="paginate.page.ariaLabel" xml:space="preserve">
<target>Seite</target>
</trans-unit>
</body>
</file>
</xliff>
10 changes: 0 additions & 10 deletions Resources/Private/Language/locallang.xlf
Original file line number Diff line number Diff line change
Expand Up @@ -53,16 +53,6 @@
<trans-unit id="news-single-video-header" xml:space="preserve">
<source>Video</source>
</trans-unit>
<trans-unit id="news.more-link.linktext" xml:space="preserve">
<source>Open News - </source>
</trans-unit>
<!--- news pagination aria labels -->
<trans-unit id="paginate.list.ariaLabel" xml:space="preserve">
<source>Pagination</source>
</trans-unit>
<trans-unit id="paginate.page.ariaLabel" xml:space="preserve">
<source>Page</source>
</trans-unit>


<!-- ContentElements labels -->
Expand Down

0 comments on commit 2d33074

Please sign in to comment.