Skip to content

Commit

Permalink
[BUGFIX] News extension list view: update no-image-markup (#380)
Browse files Browse the repository at this point in the history
In the list view of the news extension the markup for the fallback image is updated.
It uses an image-tag instead of a css-background-image now.
This works better for setting an image size.
An aria-role was added to markup the image as presentational.
  • Loading branch information
hputzek authored and Anna Färber committed Jan 15, 2018
1 parent 639608a commit 1af0474
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions Resources/Private/Extensions/News/Partials/List/SimpleList.html
Original file line number Diff line number Diff line change
Expand Up @@ -25,17 +25,17 @@
<f:if condition="{newsItem.mediaPreviews}">
<!-- media preview element -->
<f:then>
<div class="col-12 col-sm-3 news-simple-list__media-preview">
<div class="col-12 col-sm-3 news-simple-list__media-preview">
<n:link newsItem="{newsItem}" settings="{settings}" additionalAttributes="{aria-label: '{f:translate(key:\'news.more-link.linktext\', extensionName:\'Theme_t3kit\')}{newsItem.title}'}" title="{f:translate(key:'news.more-link.linktext', extensionName:'Theme_t3kit')}{newsItem.title}">
<f:alias map="{mediaElement: '{newsItem.mediaPreviews.0}'}">
<f:if condition="{mediaElement.originalResource.type} == 2">
<f:media file="{mediaElement}" width="270"/>
<f:media file="{mediaElement}" width="270"/>
</f:if>
<f:if condition="{mediaElement.originalResource.type} == 4">
<f:media file="{mediaElement}" additionalConfig="{loop: '0', autoplay: '0'}" />
</f:if>
<f:if condition="{mediaElement.originalResource.type} == 5">
<f:media file="{mediaElement}" width="270"/>
<f:media file="{mediaElement}" width="270"/>
</f:if>
</f:alias>
</n:link>
Expand All @@ -44,9 +44,9 @@
<f:else>
<f:if condition="{settings.displayDummyIfNoMedia}">
<div class="news-simple-list__img-wrap col-12 col-sm-3">
<div class="no-media-element">
<div class="news-simple-list__media-preview" style="background-image:url('{f:uri.image(src: settings.list.media.dummyImage, treatIdAsReference: 1)}');"></div>
</div>
<n:link class="no-media-element" newsItem="{newsItem}" settings="{settings}" title="{f:translate(key:'news.more-link.linktext', extensionName:'Theme_t3kit')}{newsItem.title}">
<f:image src="{settings.list.media.dummyImage}" additionalAttributes="{role: 'presentation'}" class="img-responsive" title="" alt="" maxWidth="270"/>
</n:link>
</div>
</f:if>
</f:else>
Expand Down

0 comments on commit 1af0474

Please sign in to comment.