Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matrix-media-repo is not OIDC aware, and so cannot check if the requestor for admin operations is actually an admin #620

Open
Half-Shot opened this issue Sep 20, 2024 · 0 comments

Comments

@Half-Shot
Copy link
Contributor

https://matrix-org.github.io/synapse/latest/admin_api/user_admin_api.html#get-whether-a-user-is-a-server-administrator-or-not is disabled when MSC3861 is enabled, so it's impossible to make any admin requests when using a token minted by an OIDC provider like matrix-authentication-service.

https://github.com/t2bot/matrix-media-repo/blob/main/matrix/requests_admin.go#L20-L26

I suspect the proper fix here is to make MMR OIDC aware and properly introspect the token.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant